From: Andreas Fenkart <afenkart@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Andreas Fenkart <afenkart@gmail.com>
Subject: [PATCH v3 0/1] mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR
Date: Tue, 19 Apr 2016 23:04:12 +0200 [thread overview]
Message-ID: <1461099853-15011-1-git-send-email-afenkart@gmail.com> (raw)
These are prevous submits:
v1: http://www.spinics.net/lists/linux-mmc/msg35861.html
v2: http://www.spinics.net/lists/linux-mmc/msg35869.html
Both patches tried to check for NULL and ERR_PTR, which makes the check verbose,
or loses the error code in ERR_PTR. This patch tries to make hard dependency on
pinctrl.
The driver itself does not require pinctrl to work. The pinctrl_pm_select_*
calls in runtime suspend/resume can be dummies. The code section that needs
pinctrl functions, is used to give users a heads up, that requred pinctrl states
are missing. These are needed for the swakeup workaround. But technically the pm
layer selects them.
So pinctrl is needed for user feedback and only on those chips requiring the
SWAKEUP workaround. Most chips don't require that workaround, forcing pinctrl
for those might/might not be invasive.
Select pinctrl in the drivers Kconfig section only selects only the core layer,
which does nothing without an actual driver. Depending on pinctrl will break
keystone, that doesn't have pinctrl selected.
I chose 'select pinctrl' in Kconfig, since keystone and others will not
notice the change.
v3:
- use select pinctrl in Kconf
v2:
- addressed issues from review
- race-condition issue discussed in patch description
Andreas Fenkart (1):
mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR upon error
drivers/mmc/host/Kconfig | 1 +
drivers/mmc/host/omap_hsmmc.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.8.0.rc3
next reply other threads:[~2016-04-19 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 21:04 Andreas Fenkart [this message]
2016-04-19 21:04 ` [PATCH v3 1/1] mmc: omap_hsmmc: devm_pinctrl_get returns ERR_PTR upon error Andreas Fenkart
2016-04-19 22:03 ` kbuild test robot
2016-04-19 22:12 ` Arnd Bergmann
2016-04-20 8:11 ` Dan Carpenter
2016-04-20 11:38 ` Andreas Fenkart
2016-04-20 15:13 ` Tony Lindgren
2016-04-20 22:28 ` Arnd Bergmann
2016-04-21 4:32 ` Dan Carpenter
2016-04-19 22:15 ` kbuild test robot
2016-04-19 22:19 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461099853-15011-1-git-send-email-afenkart@gmail.com \
--to=afenkart@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).