[PATCH] mmc: don't print error when allocating urb fails

[PATCH] mmc: don't print error when allocating urb fails

[Wolfram Sang]

This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses
kmalloc which already prints enough information on failure. So, let's simply
remove those "allocation failed" messages from drivers like we did already for
other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in
Tokyo a few weeks ago.


Wolfram Sang (1):
  mmc: host: vub300: don't print error when allocating urb fails

 drivers/mmc/host/vub300.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mmc: host: vub300: don't print error when allocating urb fails

[Wolfram Sang]

kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
---
 drivers/mmc/host/vub300.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 1e819f98b94f52..bb3e0d1dd35501 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -2116,13 +2116,11 @@ static int vub300_probe(struct usb_interface *interface,
 	command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
 	if (!command_out_urb) {
 		retval = -ENOMEM;
-		dev_err(&udev->dev, "not enough memory for command_out_urb\n");
 		goto error0;
 	}
 	command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
 	if (!command_res_urb) {
 		retval = -ENOMEM;
-		dev_err(&udev->dev, "not enough memory for command_res_urb\n");
 		goto error1;
 	}
 	/* this also allocates memory for our VUB300 mmc host device */
-- 
2.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mmc: host: vub300: don't print error when allocating urb fails

[Ulf Hansson]

On 11 August 2016 at 23:03, Wolfram Sang <wsa-dev@sang-engineering.com> wrote:
> kmalloc will print enough information in case of failure.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/vub300.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 1e819f98b94f52..bb3e0d1dd35501 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -2116,13 +2116,11 @@ static int vub300_probe(struct usb_interface *interface,
>         command_out_urb = usb_alloc_urb(0, GFP_KERNEL);
>         if (!command_out_urb) {
>                 retval = -ENOMEM;
> -               dev_err(&udev->dev, "not enough memory for command_out_urb\n");
>                 goto error0;
>         }
>         command_res_urb = usb_alloc_urb(0, GFP_KERNEL);
>         if (!command_res_urb) {
>                 retval = -ENOMEM;
> -               dev_err(&udev->dev, "not enough memory for command_res_urb\n");
>                 goto error1;
>         }
>         /* this also allocates memory for our VUB300 mmc host device */
> --
> 2.8.1
>