linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Alex Lemberg <alex.lemberg@sandisk.com>,
	Mateusz Nowak <mateusz.nowak@intel.com>,
	Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Dong Aisheng <dongas86@gmail.com>,
	Das Asutosh <asutoshd@codeaurora.org>,
	Zhangfei Gao <zhangfei.gao@gmail.com>,
	Dorfman Konstantin <kdorfman@codeaurora.org>,
	David Griego <david.griego@linaro.org>,
	Sahitya Tummala <stummala@codeaurora.org>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>
Subject: [PATCH V4 07/30] mmc: queue: Factor out mmc_queue_alloc_bounce_bufs()
Date: Tue, 16 Aug 2016 13:44:17 +0300	[thread overview]
Message-ID: <1471344280-16663-8-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1471344280-16663-1-git-send-email-adrian.hunter@intel.com>

In preparation for supporting a queue of requests, factor out
mmc_queue_alloc_bounce_bufs().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/card/queue.c | 45 +++++++++++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 18 deletions(-)

diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
index 6c87a065e176..82cda0c0bfe5 100644
--- a/drivers/mmc/card/queue.c
+++ b/drivers/mmc/card/queue.c
@@ -182,6 +182,31 @@ static void mmc_queue_setup_discard(struct request_queue *q,
 		queue_flag_set_unlocked(QUEUE_FLAG_SECERASE, q);
 }
 
+static bool mmc_queue_alloc_bounce_bufs(struct mmc_queue *mq,
+					unsigned int bouncesz)
+{
+	struct mmc_queue_req *mqrq_cur = mq->mqrq_cur;
+	struct mmc_queue_req *mqrq_prev = mq->mqrq_prev;
+
+	mqrq_cur->bounce_buf = kmalloc(bouncesz, GFP_KERNEL);
+	if (!mqrq_cur->bounce_buf) {
+		pr_warn("%s: unable to allocate bounce cur buffer\n",
+			mmc_card_name(mq->card));
+		return false;
+	}
+
+	mqrq_prev->bounce_buf = kmalloc(bouncesz, GFP_KERNEL);
+	if (!mqrq_prev->bounce_buf) {
+		pr_warn("%s: unable to allocate bounce prev buffer\n",
+			mmc_card_name(mq->card));
+		kfree(mqrq_cur->bounce_buf);
+		mqrq_cur->bounce_buf = NULL;
+		return false;
+	}
+
+	return true;
+}
+
 /**
  * mmc_init_queue - initialise a queue structure.
  * @mq: mmc queue
@@ -231,24 +256,8 @@ int mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card,
 		if (bouncesz > (host->max_blk_count * 512))
 			bouncesz = host->max_blk_count * 512;
 
-		if (bouncesz > 512) {
-			mqrq_cur->bounce_buf = kmalloc(bouncesz, GFP_KERNEL);
-			if (!mqrq_cur->bounce_buf) {
-				pr_warn("%s: unable to allocate bounce cur buffer\n",
-					mmc_card_name(card));
-			} else {
-				mqrq_prev->bounce_buf =
-						kmalloc(bouncesz, GFP_KERNEL);
-				if (!mqrq_prev->bounce_buf) {
-					pr_warn("%s: unable to allocate bounce prev buffer\n",
-						mmc_card_name(card));
-					kfree(mqrq_cur->bounce_buf);
-					mqrq_cur->bounce_buf = NULL;
-				}
-			}
-		}
-
-		if (mqrq_cur->bounce_buf && mqrq_prev->bounce_buf) {
+		if (bouncesz > 512 &&
+		    mmc_queue_alloc_bounce_bufs(mq, bouncesz)) {
 			blk_queue_bounce_limit(mq->queue, BLK_BOUNCE_ANY);
 			blk_queue_max_hw_sectors(mq->queue, bouncesz / 512);
 			blk_queue_max_segments(mq->queue, bouncesz / 512);
-- 
1.9.1


  parent reply	other threads:[~2016-08-16 10:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 10:44 [PATCH V4 00/30] mmc: mmc: Add Software Command Queuing Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 01/30] mmc: core: Add support for sending commands during data transfer Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 02/30] mmc: mmc_test: Add tests for sending commands during transfer Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 03/30] mmc: sdhci: Support cap_cmd_during_tfr requests Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 04/30] mmc: sdhci-pci: Set MMC_CAP_CMD_DURING_TFR for Intel eMMC controllers Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 05/30] mmc: sdhci-acpi: " Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 06/30] mmc: queue: Fix queue thread wake-up Adrian Hunter
2016-08-16 10:44 ` Adrian Hunter [this message]
2016-08-16 10:44 ` [PATCH V4 08/30] mmc: queue: Factor out mmc_queue_alloc_bounce_sgs() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 09/30] mmc: queue: Factor out mmc_queue_alloc_sgs() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 10/30] mmc: queue: Factor out mmc_queue_reqs_free_bufs() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 11/30] mmc: queue: Introduce queue depth Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 12/30] mmc: queue: Use queue depth to allocate and free Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 13/30] mmc: queue: Allocate queue of size qdepth Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 14/30] mmc: mmc: Add Command Queue definitions Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 15/30] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 16/30] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 17/30] mmc: block: Disable Command Queue while RPMB " Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 18/30] mmc: core: Do not prepare a new request twice Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 19/30] mmc: core: Export mmc_retune_hold() and mmc_retune_release() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 20/30] mmc: block: Factor out mmc_blk_requeue() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 21/30] mmc: block: Fix 4K native sector check Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 22/30] mmc: block: Use local var for mqrq_cur Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 23/30] mmc: block: Pass mqrq to mmc_blk_prep_packed_list() Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 24/30] mmc: block: Introduce queue semantics Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 25/30] mmc: queue: Share mmc request array between partitions Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 26/30] mmc: queue: Add a function to control wake-up on new requests Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 27/30] mmc: block: Add Software Command Queuing Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 28/30] mmc: mmc: Enable " Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 29/30] mmc: sdhci-pci: Enable Software Command Queuing for some Intel controllers Adrian Hunter
2016-08-16 10:44 ` [PATCH V4 30/30] mmc: sdhci-acpi: " Adrian Hunter
2016-09-12 12:36 ` [PATCH V4 00/30] mmc: mmc: Add Software Command Queuing Ulf Hansson
2016-09-13  9:41   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471344280-16663-8-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Yuliy.Izrailov@sandisk.com \
    --cc=alex.lemberg@sandisk.com \
    --cc=asutoshd@codeaurora.org \
    --cc=david.griego@linaro.org \
    --cc=dongas86@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=kdorfman@codeaurora.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mateusz.nowak@intel.com \
    --cc=riteshh@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).