From: Fabio Estevam <festevam@gmail.com>
To: ulf.hansson@linaro.org
Cc: kernel@pengutronix.de, linux-mmc@vger.kernel.org,
stefan.wahren@i2se.com, marex@denx.de,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH 2/2] mmc: mxs: Use the spinlock irq variants
Date: Thu, 27 Oct 2016 16:57:52 -0200 [thread overview]
Message-ID: <1477594672-31611-2-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1477594672-31611-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@nxp.com>
Inside an interrupt handler we should use the spin_lock_irqsave()/
spin_unlock_irqrestore() variants, so fix it accordingly.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/mmc/host/mxs-mmc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index 44ecebd..14b7548 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -189,15 +189,16 @@ static irqreturn_t mxs_mmc_irq_handler(int irq, void *dev_id)
struct mmc_command *cmd = host->cmd;
struct mmc_data *data = host->data;
struct mxs_ssp *ssp = &host->ssp;
+ unsigned long flags;
u32 stat;
- spin_lock(&host->lock);
+ spin_lock_irqsave(&host->lock, flags);
stat = readl(ssp->base + HW_SSP_CTRL1(ssp));
writel(stat & MXS_MMC_IRQ_BITS,
ssp->base + HW_SSP_CTRL1(ssp) + STMP_OFFSET_REG_CLR);
- spin_unlock(&host->lock);
+ spin_unlock_irqrestore(&host->lock, flags);
if ((stat & BM_SSP_CTRL1_SDIO_IRQ) && (stat & BM_SSP_CTRL1_SDIO_IRQ_EN))
mmc_signal_sdio_irq(host->mmc);
--
2.7.4
next prev parent reply other threads:[~2016-10-27 18:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 18:57 [PATCH 1/2] mmc: mxs: Initialize the spinlock prior to using it Fabio Estevam
2016-10-27 18:57 ` Fabio Estevam [this message]
2016-10-27 19:09 ` [PATCH 2/2] mmc: mxs: Use the spinlock irq variants Marek Vasut
2016-10-28 2:23 ` Jisheng Zhang
2016-10-28 11:40 ` Fabio Estevam
2016-10-28 11:49 ` Jisheng Zhang
2016-11-05 18:56 ` Fabio Estevam
2016-11-05 19:19 ` Fabio Estevam
2016-10-27 19:06 ` [PATCH 1/2] mmc: mxs: Initialize the spinlock prior to using it Marek Vasut
2016-10-27 19:17 ` Fabio Estevam
2016-10-27 19:56 ` Marek Vasut
2016-10-28 13:18 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477594672-31611-2-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).