Re: [PATCH V8 05/20] mmc: queue: Factor out mmc_queue_alloc_bounce_sgs()

Adrian Hunter
2016-11-30T08:51:30Z

On 30/11/16 10:17, Ulf Hansson wrote:
> On 29 November 2016 at 11:09, Adrian Hunter <adrian.hunter@intel.com> wrote:
>> In preparation for supporting a queue of requests, factor out
>> mmc_queue_alloc_bounce_sgs().
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> Reviewed-by: Harjani Ritesh <riteshh@codeaurora.org>
>> ---
>> drivers/mmc/card/queue.c | 44 ++++++++++++++++++++++++++++----------------
>> 1 file changed, 28 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
>> index 4497a218c245..3fd27c684292 100644
>> --- a/drivers/mmc/card/queue.c
>> +++ b/drivers/mmc/card/queue.c
>> @@ -211,6 +211,30 @@ static bool mmc_queue_alloc_bounce_bufs(struct mmc_queue *mq,
>> return true;
>> }
>>
>> +static int mmc_queue_alloc_bounce_sgs(struct mmc_queue *mq,
>> + unsigned int bouncesz)
>
> This causes a compiler warning about unused function, in case when
> CONFIG_MMC_BLOCK_BOUNCE is unset.
> No worries, I fixed it and amended the patch.

Thank you!