From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>, Dan O'Donovan <dan@emutex.com>
Subject: [PATCH 1/4] Revert "mmc: sdhci: Reset cmd and data circuits after tuning failure"
Date: Wed, 30 Nov 2016 11:20:11 +0200 [thread overview]
Message-ID: <1480497614-3501-2-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1480497614-3501-1-git-send-email-adrian.hunter@intel.com>
This reverts commit fe5fb2e3b58f ("mmc: sdhci: Reset cmd and data circuits
after tuning failure").
A better fix is available, and it will be applied to older stable releases,
so get this out of the way by reverting it.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org # v4.9+
---
drivers/mmc/host/sdhci.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 7f2526c9572f..e761fe2aa99e 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2090,10 +2090,6 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
if (!host->tuning_done) {
pr_info(DRIVER_NAME ": Timeout waiting for Buffer Read Ready interrupt during tuning procedure, falling back to fixed sampling clock\n");
-
- sdhci_do_reset(host, SDHCI_RESET_CMD);
- sdhci_do_reset(host, SDHCI_RESET_DATA);
-
ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);
ctrl &= ~SDHCI_CTRL_TUNED_CLK;
ctrl &= ~SDHCI_CTRL_EXEC_TUNING;
--
1.9.1
next prev parent reply other threads:[~2016-11-30 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 9:20 [PATCH 0/4] mmc: sdhci: Fix recovery from tuning timeout Adrian Hunter
2016-11-30 9:20 ` Adrian Hunter [this message]
2016-11-30 9:20 ` [PATCH 2/4] " Adrian Hunter
2016-11-30 10:06 ` Ulf Hansson
2016-11-30 10:17 ` Adrian Hunter
2016-12-01 8:01 ` Ulf Hansson
2016-11-30 9:20 ` [PATCH 3/4] mmc: sdhci: Fix tuning reset after exhausting the maximum number of loops Adrian Hunter
2016-11-30 9:20 ` [PATCH 4/4] mmc: sdhci: Always allow tuning to fall back to fixed sampling Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480497614-3501-2-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=dan@emutex.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox