public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: linux-mmc@vger.kernel.org
Cc: adrian.hunter@intel.com, cja@gmx.net, darcari@redhat.com,
	Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH] sdhci-acpi: support deferred probe
Date: Mon, 26 Dec 2016 10:28:16 +0800	[thread overview]
Message-ID: <1482719296-4783-1-git-send-email-rui.zhang@intel.com> (raw)

With commit
67bf5156edc4 (gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get()),
mmc_gpiod_request_cd() returns -EPROBE_DEFER if GPIO is not ready
when sdhci-acpi driver is probed, and sdhci-acpi driver should be probed
again later in this case.

This fixes an order issue when both GPIO and sdhci-acpi drivers are built as
modules.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177101
Tested-by: Jonas Aaberg <cja@gmx.net>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/mmc/host/sdhci-acpi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 160f695..5440323 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -466,7 +466,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 	if (sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD)) {
 		bool v = sdhci_acpi_flag(c, SDHCI_ACPI_SD_CD_OVERRIDE_LEVEL);
 
-		if (mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0, NULL)) {
+		err = mmc_gpiod_request_cd(host->mmc, NULL, 0, v, 0, NULL);
+		if (err) {
+			if (err == -EPROBE_DEFER)
+				goto err_free;
 			dev_warn(dev, "failed to setup card detect gpio\n");
 			c->use_runtime_pm = false;
 		}
-- 
2.7.4


             reply	other threads:[~2016-12-26  2:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-26  2:28 Zhang Rui [this message]
2017-01-05 10:06 ` [PATCH] sdhci-acpi: support deferred probe Adrian Hunter
2017-01-10 15:38 ` Ulf Hansson
2017-01-11  0:58   ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482719296-4783-1-git-send-email-rui.zhang@intel.com \
    --to=rui.zhang@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=cja@gmx.net \
    --cc=darcari@redhat.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox