From: Joe Perches <joe@perches.com>
To: Ziyuan Xu <xzy.xu@rock-chips.com>,
ulf.hansson@linaro.org, jh80.chung@samsung.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style
Date: Wed, 04 Jan 2017 10:32:21 -0800 [thread overview]
Message-ID: <1483554741.21292.9.camel@perches.com> (raw)
In-Reply-To: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com>
On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote:
> Let's fix the warnings from checkpatch.pl:
>
> - line over 80 characters;
> - block comments should align the * on each Lines;
> - statements not starting on a tabstop.
>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> ---
>
> drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
[]
> @@ -94,7 +94,8 @@ struct idmac_desc {
>
> __le32 des1; /* Buffer sizes */
> #define IDMAC_SET_BUFFER1_SIZE(d, s) \
> - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff)))
> + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \
> + (cpu_to_le32((s) & 0x1fff)))
Please look to improve code rather than just shut up
the brainless checkpatch script.
If this is really valuable, it'd probably be better as
an inline function, or as it's only used once, just
as direct code in that one place.
next prev parent reply other threads:[~2017-01-04 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170104125752epcas4p2a801fce6fd376d02d7440ad4bfe1716b@epcas4p2.samsung.com>
2017-01-04 12:52 ` [PATCH] mmc: dw_mmc: Fix some coding style Ziyuan Xu
2017-01-04 13:03 ` Andy Shevchenko
2017-01-04 18:32 ` Joe Perches [this message]
2017-01-05 7:30 ` Ziyuan
2017-01-05 1:19 ` Jaehoon Chung
2017-01-05 2:24 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483554741.21292.9.camel@perches.com \
--to=joe@perches.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xzy.xu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox