From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style Date: Wed, 04 Jan 2017 10:32:21 -0800 Message-ID: <1483554741.21292.9.camel@perches.com> References: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org To: Ziyuan Xu , ulf.hansson@linaro.org, jh80.chung@samsung.com Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mmc@vger.kernel.org On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote: > Let's fix the warnings from checkpatch.pl: > > - line over 80 characters; > - block comments should align the * on each Lines; > - statements not starting on a tabstop. > > Signed-off-by: Ziyuan Xu > --- > > drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++---------------- > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c [] > @@ -94,7 +94,8 @@ struct idmac_desc { > > __le32 des1; /* Buffer sizes */ > #define IDMAC_SET_BUFFER1_SIZE(d, s) \ > - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff))) > + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \ > + (cpu_to_le32((s) & 0x1fff))) Please look to improve code rather than just shut up the brainless checkpatch script. If this is really valuable, it'd probably be better as an inline function, or as it's only used once, just as direct code in that one place.