Re: [PATCH RFC 22/39] mmc: block: Prepare CQE data

Linus Walleij
2017-02-15T13:49:26Z

On Fri, Feb 10, 2017 at 1:55 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:

> Enhance mmc_blk_data_prep() to support CQE requests.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Hey:

> +#include <linux/ioprio.h>
(...)
> + if (IOPRIO_PRIO_CLASS(req_get_ioprio(req)) == IOPRIO_CLASS_RT)
> + brq->data.flags |= MMC_DATA_PRIO;

What is this?

Why are we not already doing this and why is it not a separate patch?

> /*
> * Data tag is used only during writing meta data to speed
> * up write and any subsequent read of this meta data
> */

Is this comment still true?

> - *do_data_tag = card->ext_csd.data_tag_unit_size &&
> - (req->cmd_flags & REQ_META) &&
> - (rq_data_dir(req) == WRITE) &&
> - ((brq->data.blocks * brq->data.blksz) >=
> - card->ext_csd.data_tag_unit_size);
> + do_data_tag = card->ext_csd.data_tag_unit_size &&
> + (req->cmd_flags & REQ_META) &&
> + (rq_data_dir(req) == WRITE) &&
> + ((brq->data.blocks * brq->data.blksz) >=
> + card->ext_csd.data_tag_unit_size);
> +
> + if (do_data_tag)
> + brq->data.flags |= MMC_DATA_DAT_TAG;

Because it seems to be more unconditionally used now.

Yours,
Linus Walleij