Re: [PATCH RFC 05/39] mmc: mmc: Add functions to enable / disable the Command Queue

Ulf Hansson
2017-02-17T12:21:16Z

On 15 February 2017 at 13:52, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Feb 10, 2017 at 1:55 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
>> Add helper functions to enable or disable the Command Queue.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> I think I asked this before but why?

There are certain other requests, like for RPMB, which requires CMDQ
to be "temporary" disabled.

Seems like a little more information the change log would be
appreciated to understand why we need to add these functions.

>
> If the card has this feature, certainly we should just exploit it?
>
> If some card has a problem with it, I guess it is broken and should
> simply have this operation blacklisted.
>
> Yours,
> Linus Walleij

Kind regards
Uffe