Re: [PATCH RFC 05/39] mmc: mmc: Add functions to enable / disable the Command Queue

Linus Walleij
2017-02-23T14:54:34Z

On Fri, Feb 17, 2017 at 1:21 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 15 February 2017 at 13:52, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, Feb 10, 2017 at 1:55 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>
>>> Add helper functions to enable or disable the Command Queue.
>>>
>>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>>
>> I think I asked this before but why?
>
> There are certain other requests, like for RPMB, which requires CMDQ
> to be "temporary" disabled.

Ah my comment is stupid.

I specifically want to know why we should be able to disable
it from sysfs.

I don't see the point in that, just giving userspace another gun
to shoot itself in the foot.

Yours,
Linus Walleij