public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Alex Lemberg <alex.lemberg@sandisk.com>,
	Mateusz Nowak <mateusz.nowak@intel.com>,
	Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Dong Aisheng <dongas86@gmail.com>,
	Das Asutosh <asutoshd@codeaurora.org>,
	Zhangfei Gao <zhangfei.gao@gmail.com>,
	Dorfman Konstantin <kdorfman@codeaurora.org>,
	David Griego <david.griego@linaro.org>,
	Sahitya Tummala <stummala@codeaurora.org>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH V1 03/18] mmc: mmc_test: Disable Command Queue while mmc_test is used
Date: Mon,  6 Mar 2017 11:10:58 +0200	[thread overview]
Message-ID: <1488791473-24981-4-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1488791473-24981-1-git-send-email-adrian.hunter@intel.com>

Normal read and write commands may not be used while the command queue is
enabled. Disable the Command Queue when mmc_test is probed and re-enable it
when it is removed.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Harjani Ritesh <riteshh@codeaurora.org>
---
 drivers/mmc/core/mmc.c      |  7 +++++++
 drivers/mmc/core/mmc_test.c | 14 ++++++++++++++
 include/linux/mmc/card.h    |  2 ++
 3 files changed, 23 insertions(+)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 5727a0842a59..d1f0c4b247ac 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1790,6 +1790,13 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
 	}
 
 	/*
+	 * In some cases (e.g. RPMB or mmc_test), the Command Queue must be
+	 * disabled for a time, so a flag is needed to indicate to re-enable the
+	 * Command Queue.
+	 */
+	card->reenable_cmdq = card->ext_csd.cmdq_en;
+
+	/*
 	 * The mandatory minimum values are defined for packed command.
 	 * read: 5, write: 3
 	 */
diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index f99ac3123fd2..fd1b4b8510b9 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -26,6 +26,7 @@
 #include "card.h"
 #include "host.h"
 #include "bus.h"
+#include "mmc_ops.h"
 
 #define RESULT_OK		0
 #define RESULT_FAIL		1
@@ -3264,6 +3265,14 @@ static int mmc_test_probe(struct mmc_card *card)
 	if (ret)
 		return ret;
 
+	if (card->ext_csd.cmdq_en) {
+		mmc_claim_host(card->host);
+		ret = mmc_cmdq_disable(card);
+		mmc_release_host(card->host);
+		if (ret)
+			return ret;
+	}
+
 	dev_info(&card->dev, "Card claimed for testing.\n");
 
 	return 0;
@@ -3271,6 +3280,11 @@ static int mmc_test_probe(struct mmc_card *card)
 
 static void mmc_test_remove(struct mmc_card *card)
 {
+	if (card->reenable_cmdq) {
+		mmc_claim_host(card->host);
+		mmc_cmdq_enable(card);
+		mmc_release_host(card->host);
+	}
 	mmc_test_free_result(card);
 	mmc_test_free_dbgfs_file(card);
 }
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index 94637796b99c..85b5f2bc8bb9 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -269,6 +269,8 @@ struct mmc_card {
 #define MMC_QUIRK_TRIM_BROKEN	(1<<12)		/* Skip trim */
 #define MMC_QUIRK_BROKEN_HPI	(1<<13)		/* Disable broken HPI support */
 
+	bool			reenable_cmdq;	/* Re-enable Command Queue */
+
 	unsigned int		erase_size;	/* erase size in sectors */
  	unsigned int		erase_shift;	/* if erase unit is power 2 */
  	unsigned int		pref_erase;	/* in sectors */
-- 
1.9.1


  parent reply	other threads:[~2017-03-06  9:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170306091701epcas4p30ef050e2e5bd1616457a6347de9b6717@epcas4p3.samsung.com>
2017-03-06  9:10 ` [PATCH V1 00/18] mmc: Add Command Queue support Adrian Hunter
2017-03-06  9:10   ` [PATCH V1 01/18] mmc: queue: Share mmc request array between partitions Adrian Hunter
2017-03-06  9:10   ` [PATCH V1 02/18] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2017-03-06  9:10   ` Adrian Hunter [this message]
2017-03-06  9:10   ` [PATCH V1 04/18] mmc: block: Disable Command Queue while RPMB is used Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 05/18] mmc: block: Change mmc_apply_rel_rw() to get block address from the request Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 06/18] mmc: block: Factor out data preparation Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 07/18] mmc: core: Factor out debug prints from mmc_start_request() Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 08/18] mmc: core: Factor out mrq preparation " Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 09/18] mmc: core: Add mmc_retune_hold_now() Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 10/18] mmc: core: Add members to mmc_request and mmc_data for CQE's Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 11/18] mmc: host: Add CQE interface Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 12/18] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 13/18] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 14/18] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 15/18] mmc: mmc: Enable CQE's Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 16/18] mmc: block: Prepare CQE data Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 17/18] mmc: block: Add CQE support Adrian Hunter
2017-03-06  9:11   ` [PATCH V1 18/18] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-03-08  5:18   ` [PATCH V1 00/18] mmc: Add Command Queue support Jaehoon Chung
2017-03-08  8:08     ` Adrian Hunter
2017-03-08 13:27       ` Jaehoon Chung
2017-03-09  2:47         ` Shawn Lin
2017-03-09  8:14           ` Shawn Lin
2017-03-09  8:52         ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488791473-24981-4-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Yuliy.Izrailov@sandisk.com \
    --cc=alex.lemberg@sandisk.com \
    --cc=asutoshd@codeaurora.org \
    --cc=david.griego@linaro.org \
    --cc=dongas86@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=kdorfman@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mateusz.nowak@intel.com \
    --cc=riteshh@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox