From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Alex Lemberg <alex.lemberg@sandisk.com>,
Mateusz Nowak <mateusz.nowak@intel.com>,
Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Dong Aisheng <dongas86@gmail.com>,
Das Asutosh <asutoshd@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Dorfman Konstantin <kdorfman@codeaurora.org>,
David Griego <david.griego@linaro.org>,
Sahitya Tummala <stummala@codeaurora.org>,
Harjani Ritesh <riteshh@codeaurora.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH V1 04/18] mmc: block: Disable Command Queue while RPMB is used
Date: Mon, 6 Mar 2017 11:10:59 +0200 [thread overview]
Message-ID: <1488791473-24981-5-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1488791473-24981-1-git-send-email-adrian.hunter@intel.com>
RPMB does not allow Command Queue commands. Disable and re-enable the
Command Queue when switching.
Note that the driver only switches partitions when the queue is empty.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Harjani Ritesh <riteshh@codeaurora.org>
---
drivers/mmc/core/block.c | 46 ++++++++++++++++++++++++++++++++++++++--------
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index efd640c97b0b..bd0defc5db3b 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -721,10 +721,41 @@ static int mmc_blk_compat_ioctl(struct block_device *bdev, fmode_t mode,
#endif
};
+static int mmc_blk_part_switch_pre(struct mmc_card *card,
+ unsigned int part_type)
+{
+ int ret = 0;
+
+ if (part_type == EXT_CSD_PART_CONFIG_ACC_RPMB) {
+ if (card->ext_csd.cmdq_en) {
+ ret = mmc_cmdq_disable(card);
+ if (ret)
+ return ret;
+ }
+ mmc_retune_pause(card->host);
+ }
+
+ return ret;
+}
+
+static int mmc_blk_part_switch_post(struct mmc_card *card,
+ unsigned int part_type)
+{
+ int ret = 0;
+
+ if (part_type == EXT_CSD_PART_CONFIG_ACC_RPMB) {
+ mmc_retune_unpause(card->host);
+ if (card->reenable_cmdq && !card->ext_csd.cmdq_en)
+ ret = mmc_cmdq_enable(card);
+ }
+
+ return ret;
+}
+
static inline int mmc_blk_part_switch(struct mmc_card *card,
struct mmc_blk_data *md)
{
- int ret;
+ int ret = 0;
struct mmc_blk_data *main_md = dev_get_drvdata(&card->dev);
if (main_md->part_curr == md->part_type)
@@ -733,8 +764,9 @@ static inline int mmc_blk_part_switch(struct mmc_card *card,
if (mmc_card_mmc(card)) {
u8 part_config = card->ext_csd.part_config;
- if (md->part_type == EXT_CSD_PART_CONFIG_ACC_RPMB)
- mmc_retune_pause(card->host);
+ ret = mmc_blk_part_switch_pre(card, md->part_type);
+ if (ret)
+ return ret;
part_config &= ~EXT_CSD_PART_CONFIG_ACC_MASK;
part_config |= md->part_type;
@@ -743,19 +775,17 @@ static inline int mmc_blk_part_switch(struct mmc_card *card,
EXT_CSD_PART_CONFIG, part_config,
card->ext_csd.part_time);
if (ret) {
- if (md->part_type == EXT_CSD_PART_CONFIG_ACC_RPMB)
- mmc_retune_unpause(card->host);
+ mmc_blk_part_switch_post(card, md->part_type);
return ret;
}
card->ext_csd.part_config = part_config;
- if (main_md->part_curr == EXT_CSD_PART_CONFIG_ACC_RPMB)
- mmc_retune_unpause(card->host);
+ ret = mmc_blk_part_switch_post(card, main_md->part_curr);
}
main_md->part_curr = md->part_type;
- return 0;
+ return ret;
}
static int mmc_sd_num_wr_blocks(struct mmc_card *card, u32 *written_blocks)
--
1.9.1
next prev parent reply other threads:[~2017-03-06 9:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170306091701epcas4p30ef050e2e5bd1616457a6347de9b6717@epcas4p3.samsung.com>
2017-03-06 9:10 ` [PATCH V1 00/18] mmc: Add Command Queue support Adrian Hunter
2017-03-06 9:10 ` [PATCH V1 01/18] mmc: queue: Share mmc request array between partitions Adrian Hunter
2017-03-06 9:10 ` [PATCH V1 02/18] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2017-03-06 9:10 ` [PATCH V1 03/18] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2017-03-06 9:10 ` Adrian Hunter [this message]
2017-03-06 9:11 ` [PATCH V1 05/18] mmc: block: Change mmc_apply_rel_rw() to get block address from the request Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 06/18] mmc: block: Factor out data preparation Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 07/18] mmc: core: Factor out debug prints from mmc_start_request() Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 08/18] mmc: core: Factor out mrq preparation " Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 09/18] mmc: core: Add mmc_retune_hold_now() Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 10/18] mmc: core: Add members to mmc_request and mmc_data for CQE's Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 11/18] mmc: host: Add CQE interface Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 12/18] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 13/18] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 14/18] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 15/18] mmc: mmc: Enable CQE's Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 16/18] mmc: block: Prepare CQE data Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 17/18] mmc: block: Add CQE support Adrian Hunter
2017-03-06 9:11 ` [PATCH V1 18/18] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-03-08 5:18 ` [PATCH V1 00/18] mmc: Add Command Queue support Jaehoon Chung
2017-03-08 8:08 ` Adrian Hunter
2017-03-08 13:27 ` Jaehoon Chung
2017-03-09 2:47 ` Shawn Lin
2017-03-09 8:14 ` Shawn Lin
2017-03-09 8:52 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488791473-24981-5-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Yuliy.Izrailov@sandisk.com \
--cc=alex.lemberg@sandisk.com \
--cc=asutoshd@codeaurora.org \
--cc=david.griego@linaro.org \
--cc=dongas86@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kdorfman@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mateusz.nowak@intel.com \
--cc=riteshh@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbyravarasu@nvidia.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox