From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Alex Lemberg <alex.lemberg@sandisk.com>,
Mateusz Nowak <mateusz.nowak@intel.com>,
Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Dong Aisheng <dongas86@gmail.com>,
Das Asutosh <asutoshd@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Dorfman Konstantin <kdorfman@codeaurora.org>,
David Griego <david.griego@linaro.org>,
Sahitya Tummala <stummala@codeaurora.org>,
Harjani Ritesh <riteshh@codeaurora.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH V2 17/22] mmc: core: Add support for handling CQE requests
Date: Mon, 13 Mar 2017 14:36:48 +0200 [thread overview]
Message-ID: <1489408613-26915-18-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1489408613-26915-1-git-send-email-adrian.hunter@intel.com>
Add core support for handling CQE requests, including starting, completing
and recovering.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
drivers/mmc/core/core.c | 147 +++++++++++++++++++++++++++++++++++++++++++++--
include/linux/mmc/core.h | 6 ++
2 files changed, 148 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 480dfd5d9c13..07bd48fb70c6 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -265,7 +265,8 @@ static void __mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
host->ops->request(host, mrq);
}
-static void mmc_mrq_pr_debug(struct mmc_host *host, struct mmc_request *mrq)
+static void mmc_mrq_pr_debug(struct mmc_host *host, struct mmc_request *mrq,
+ bool cqe)
{
if (mrq->sbc) {
pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n",
@@ -274,9 +275,12 @@ static void mmc_mrq_pr_debug(struct mmc_host *host, struct mmc_request *mrq)
}
if (mrq->cmd) {
- pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
- mmc_hostname(host), mrq->cmd->opcode, mrq->cmd->arg,
- mrq->cmd->flags);
+ pr_debug("%s: starting %sCMD%u arg %08x flags %08x\n",
+ mmc_hostname(host), cqe ? "CQE direct " : "",
+ mrq->cmd->opcode, mrq->cmd->arg, mrq->cmd->flags);
+ } else if (cqe) {
+ pr_debug("%s: starting CQE transfer for tag %d blkaddr %u\n",
+ mmc_hostname(host), mrq->tag, mrq->data->blk_addr);
}
if (mrq->data) {
@@ -344,7 +348,7 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
if (mmc_card_removed(host->card))
return -ENOMEDIUM;
- mmc_mrq_pr_debug(host, mrq);
+ mmc_mrq_pr_debug(host, mrq, false);
WARN_ON(!host->claimed);
@@ -358,6 +362,139 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq)
return 0;
}
+int mmc_cqe_start_req(struct mmc_host *host, struct mmc_request *mrq)
+{
+ int err;
+
+ /* Caller must hold retuning while CQE is in use */
+ err = mmc_retune(host);
+ if (err)
+ goto out_err;
+
+ mrq->host = host;
+
+ mmc_mrq_pr_debug(host, mrq, true);
+
+ err = mmc_mrq_prep(host, mrq);
+ if (err)
+ goto out_err;
+
+ err = host->cqe_ops->cqe_request(host, mrq);
+ if (err)
+ goto out_err;
+
+ trace_mmc_request_start(host, mrq);
+
+ return 0;
+
+out_err:
+ if (mrq->cmd) {
+ pr_debug("%s: failed to start CQE direct CMD%u, error %d\n",
+ mmc_hostname(host), mrq->cmd->opcode, err);
+ } else {
+ pr_debug("%s: failed to start CQE transfer for tag %d, error %d\n",
+ mmc_hostname(host), mrq->tag, err);
+ }
+ return err;
+}
+EXPORT_SYMBOL(mmc_cqe_start_req);
+
+void __mmc_cqe_request_done(struct mmc_host *host, struct mmc_request *mrq)
+{
+ mmc_should_fail_request(host, mrq);
+
+ /* Flag re-tuning needed on CRC errors */
+ if ((mrq->cmd && mrq->cmd->error == -EILSEQ) ||
+ (mrq->data && mrq->data->error == -EILSEQ))
+ mmc_retune_needed(host);
+
+ trace_mmc_request_done(host, mrq);
+
+ if (mrq->cmd) {
+ pr_debug("%s: CQE req done (direct CMD%u): %d\n",
+ mmc_hostname(host), mrq->cmd->opcode, mrq->cmd->error);
+ } else {
+ pr_debug("%s: CQE transfer done tag %d\n",
+ mmc_hostname(host), mrq->tag);
+ }
+
+ if (mrq->data) {
+ pr_debug("%s: %d bytes transferred: %d\n",
+ mmc_hostname(host),
+ mrq->data->bytes_xfered, mrq->data->error);
+ }
+}
+EXPORT_SYMBOL(__mmc_cqe_request_done);
+
+/**
+ * mmc_cqe_request_done - CQE has finished processing an MMC request
+ * @host: MMC host which completed request
+ * @mrq: MMC request which completed
+ *
+ * CQE drivers should call this function when they have completed
+ * their processing of a request.
+ */
+void mmc_cqe_request_done(struct mmc_host *host, struct mmc_request *mrq)
+{
+ __mmc_cqe_request_done(host, mrq);
+
+ mrq->done(mrq);
+}
+EXPORT_SYMBOL(mmc_cqe_request_done);
+
+/**
+ * mmc_cqe_post_req - CQE post process of a completed MMC request
+ * @host: MMC host
+ * @mrq: MMC request to be processed
+ */
+void mmc_cqe_post_req(struct mmc_host *host, struct mmc_request *mrq)
+{
+ if (host->cqe_ops->cqe_post_req)
+ host->cqe_ops->cqe_post_req(host, mrq);
+}
+EXPORT_SYMBOL(mmc_cqe_post_req);
+
+/* Arbitrary 1 second timeout */
+#define MMC_CQE_RECOVERY_TIMEOUT 1000
+
+int mmc_cqe_recovery(struct mmc_host *host, bool forget_reqs)
+{
+ struct mmc_command cmd;
+ int err;
+
+ mmc_retune_hold_now(host);
+
+ /*
+ * Recovery is expected seldom, if at all, but it reduces performance,
+ * so make sure it is not completely silent.
+ */
+ pr_warn("%s: running CQE recovery\n", mmc_hostname(host));
+
+ host->cqe_ops->cqe_recovery_start(host);
+
+ memset(&cmd, 0, sizeof(cmd));
+ cmd.opcode = MMC_STOP_TRANSMISSION,
+ cmd.flags = MMC_RSP_R1B | MMC_CMD_AC,
+ cmd.flags &= ~MMC_RSP_CRC; /* Ignore CRC */
+ cmd.busy_timeout = MMC_CQE_RECOVERY_TIMEOUT,
+ mmc_wait_for_cmd(host, &cmd, 0);
+
+ memset(&cmd, 0, sizeof(cmd));
+ cmd.opcode = MMC_CMDQ_TASK_MGMT;
+ cmd.arg = 1; /* Discard entire queue */
+ cmd.flags = MMC_RSP_R1B | MMC_CMD_AC;
+ cmd.flags &= ~MMC_RSP_CRC; /* Ignore CRC */
+ cmd.busy_timeout = MMC_CQE_RECOVERY_TIMEOUT,
+ err = mmc_wait_for_cmd(host, &cmd, 0);
+
+ host->cqe_ops->cqe_recovery_finish(host, forget_reqs);
+
+ mmc_retune_release(host);
+
+ return err;
+}
+EXPORT_SYMBOL(mmc_cqe_recovery);
+
/**
* mmc_start_bkops - start BKOPS for supported cards
* @card: MMC card to start BKOPS
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index bf1788a224e6..1aae492f9515 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -174,6 +174,12 @@ struct mmc_async_req *mmc_start_areq(struct mmc_host *host,
int mmc_wait_for_cmd(struct mmc_host *host, struct mmc_command *cmd,
int retries);
+int mmc_cqe_start_req(struct mmc_host *host, struct mmc_request *mrq);
+void __mmc_cqe_request_done(struct mmc_host *host, struct mmc_request *mrq);
+void mmc_cqe_request_done(struct mmc_host *host, struct mmc_request *mrq);
+void mmc_cqe_post_req(struct mmc_host *host, struct mmc_request *mrq);
+int mmc_cqe_recovery(struct mmc_host *host, bool forget_reqs);
+
int mmc_hw_reset(struct mmc_host *host);
void mmc_set_data_timeout(struct mmc_data *data, const struct mmc_card *card);
--
1.9.1
next prev parent reply other threads:[~2017-03-13 12:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 12:36 [PATCH V2 00/22] mmc: Add Command Queue support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 01/22] mmc: block: Fix is_waiting_last_req set incorrectly Adrian Hunter
2017-03-14 16:22 ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 02/22] mmc: block: Fix cmd error reset failure path Adrian Hunter
2017-03-14 16:22 ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 03/22] mmc: block: Use local var for mqrq_cur Adrian Hunter
2017-04-08 17:37 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 04/22] mmc: block: Introduce queue semantics Adrian Hunter
2017-04-08 17:40 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 05/22] mmc: queue: Share mmc request array between partitions Adrian Hunter
2017-04-08 17:41 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 06/22] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2017-04-08 17:39 ` Linus Walleij
2017-04-10 11:01 ` Ulf Hansson
2017-04-10 11:11 ` Adrian Hunter
2017-04-10 13:02 ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 07/22] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2017-04-08 17:43 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 08/22] mmc: block: Disable Command Queue while RPMB " Adrian Hunter
2017-04-08 17:44 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 09/22] mmc: block: Change mmc_apply_rel_rw() to get block address from the request Adrian Hunter
2017-04-10 13:49 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 10/22] mmc: block: Factor out data preparation Adrian Hunter
2017-04-10 13:52 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 11/22] mmc: core: Factor out debug prints from mmc_start_request() Adrian Hunter
2017-04-10 13:53 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 12/22] mmc: core: Factor out mrq preparation " Adrian Hunter
2017-04-10 13:54 ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 13/22] mmc: core: Add mmc_retune_hold_now() Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 14/22] mmc: core: Add members to mmc_request and mmc_data for CQE's Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 15/22] mmc: host: Add CQE interface Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 16/22] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-03-13 12:36 ` Adrian Hunter [this message]
2017-03-13 12:36 ` [PATCH V2 18/22] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 19/22] mmc: mmc: Enable CQE's Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 20/22] mmc: block: Prepare CQE data Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 21/22] mmc: block: Add CQE support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 22/22] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-04-08 17:37 ` [PATCH V2 00/22] mmc: Add Command Queue support Linus Walleij
2017-04-10 13:53 ` Ulf Hansson
2017-04-22 7:45 ` Adrian Hunter
2017-04-24 8:12 ` Linus Walleij
2017-04-24 9:14 ` Bough Chen
2017-06-15 11:38 ` Adrian Hunter
2017-06-15 11:49 ` Bough Chen
2017-06-20 8:01 ` Bough Chen
2017-06-20 9:04 ` Adrian Hunter
2017-07-04 10:21 ` Bough Chen
2017-07-06 10:48 ` Adrian Hunter
2017-04-25 13:28 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489408613-26915-18-git-send-email-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=Yuliy.Izrailov@sandisk.com \
--cc=alex.lemberg@sandisk.com \
--cc=asutoshd@codeaurora.org \
--cc=david.griego@linaro.org \
--cc=dongas86@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kdorfman@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mateusz.nowak@intel.com \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbyravarasu@nvidia.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox