public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Alex Lemberg <alex.lemberg@sandisk.com>,
	Mateusz Nowak <mateusz.nowak@intel.com>,
	Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Dong Aisheng <dongas86@gmail.com>,
	Das Asutosh <asutoshd@codeaurora.org>,
	Zhangfei Gao <zhangfei.gao@gmail.com>,
	Dorfman Konstantin <kdorfman@codeaurora.org>,
	David Griego <david.griego@linaro.org>,
	Sahitya Tummala <stummala@codeaurora.org>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH V2 08/22] mmc: block: Disable Command Queue while RPMB is used
Date: Mon, 13 Mar 2017 14:36:39 +0200	[thread overview]
Message-ID: <1489408613-26915-9-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1489408613-26915-1-git-send-email-adrian.hunter@intel.com>

RPMB does not allow Command Queue commands. Disable and re-enable the
Command Queue when switching.

Note that the driver only switches partitions when the queue is empty.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Harjani Ritesh <riteshh@codeaurora.org>
---
 drivers/mmc/core/block.c | 46 ++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 38 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index b9890dcfb913..849b55654163 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -728,10 +728,41 @@ static int mmc_blk_compat_ioctl(struct block_device *bdev, fmode_t mode,
 #endif
 };
 
+static int mmc_blk_part_switch_pre(struct mmc_card *card,
+				   unsigned int part_type)
+{
+	int ret = 0;
+
+	if (part_type == EXT_CSD_PART_CONFIG_ACC_RPMB) {
+		if (card->ext_csd.cmdq_en) {
+			ret = mmc_cmdq_disable(card);
+			if (ret)
+				return ret;
+		}
+		mmc_retune_pause(card->host);
+	}
+
+	return ret;
+}
+
+static int mmc_blk_part_switch_post(struct mmc_card *card,
+				    unsigned int part_type)
+{
+	int ret = 0;
+
+	if (part_type == EXT_CSD_PART_CONFIG_ACC_RPMB) {
+		mmc_retune_unpause(card->host);
+		if (card->reenable_cmdq && !card->ext_csd.cmdq_en)
+			ret = mmc_cmdq_enable(card);
+	}
+
+	return ret;
+}
+
 static inline int mmc_blk_part_switch(struct mmc_card *card,
 				      struct mmc_blk_data *md)
 {
-	int ret;
+	int ret = 0;
 	struct mmc_blk_data *main_md = dev_get_drvdata(&card->dev);
 
 	if (main_md->part_curr == md->part_type)
@@ -740,8 +771,9 @@ static inline int mmc_blk_part_switch(struct mmc_card *card,
 	if (mmc_card_mmc(card)) {
 		u8 part_config = card->ext_csd.part_config;
 
-		if (md->part_type == EXT_CSD_PART_CONFIG_ACC_RPMB)
-			mmc_retune_pause(card->host);
+		ret = mmc_blk_part_switch_pre(card, md->part_type);
+		if (ret)
+			return ret;
 
 		part_config &= ~EXT_CSD_PART_CONFIG_ACC_MASK;
 		part_config |= md->part_type;
@@ -750,19 +782,17 @@ static inline int mmc_blk_part_switch(struct mmc_card *card,
 				 EXT_CSD_PART_CONFIG, part_config,
 				 card->ext_csd.part_time);
 		if (ret) {
-			if (md->part_type == EXT_CSD_PART_CONFIG_ACC_RPMB)
-				mmc_retune_unpause(card->host);
+			mmc_blk_part_switch_post(card, md->part_type);
 			return ret;
 		}
 
 		card->ext_csd.part_config = part_config;
 
-		if (main_md->part_curr == EXT_CSD_PART_CONFIG_ACC_RPMB)
-			mmc_retune_unpause(card->host);
+		ret = mmc_blk_part_switch_post(card, main_md->part_curr);
 	}
 
 	main_md->part_curr = md->part_type;
-	return 0;
+	return ret;
 }
 
 static int mmc_sd_num_wr_blocks(struct mmc_card *card, u32 *written_blocks)
-- 
1.9.1


  parent reply	other threads:[~2017-03-13 12:43 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 12:36 [PATCH V2 00/22] mmc: Add Command Queue support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 01/22] mmc: block: Fix is_waiting_last_req set incorrectly Adrian Hunter
2017-03-14 16:22   ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 02/22] mmc: block: Fix cmd error reset failure path Adrian Hunter
2017-03-14 16:22   ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 03/22] mmc: block: Use local var for mqrq_cur Adrian Hunter
2017-04-08 17:37   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 04/22] mmc: block: Introduce queue semantics Adrian Hunter
2017-04-08 17:40   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 05/22] mmc: queue: Share mmc request array between partitions Adrian Hunter
2017-04-08 17:41   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 06/22] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2017-04-08 17:39   ` Linus Walleij
2017-04-10 11:01   ` Ulf Hansson
2017-04-10 11:11     ` Adrian Hunter
2017-04-10 13:02       ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 07/22] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2017-04-08 17:43   ` Linus Walleij
2017-03-13 12:36 ` Adrian Hunter [this message]
2017-04-08 17:44   ` [PATCH V2 08/22] mmc: block: Disable Command Queue while RPMB " Linus Walleij
2017-03-13 12:36 ` [PATCH V2 09/22] mmc: block: Change mmc_apply_rel_rw() to get block address from the request Adrian Hunter
2017-04-10 13:49   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 10/22] mmc: block: Factor out data preparation Adrian Hunter
2017-04-10 13:52   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 11/22] mmc: core: Factor out debug prints from mmc_start_request() Adrian Hunter
2017-04-10 13:53   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 12/22] mmc: core: Factor out mrq preparation " Adrian Hunter
2017-04-10 13:54   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 13/22] mmc: core: Add mmc_retune_hold_now() Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 14/22] mmc: core: Add members to mmc_request and mmc_data for CQE's Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 15/22] mmc: host: Add CQE interface Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 16/22] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 17/22] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 18/22] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 19/22] mmc: mmc: Enable CQE's Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 20/22] mmc: block: Prepare CQE data Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 21/22] mmc: block: Add CQE support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 22/22] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-04-08 17:37 ` [PATCH V2 00/22] mmc: Add Command Queue support Linus Walleij
2017-04-10 13:53 ` Ulf Hansson
2017-04-22  7:45   ` Adrian Hunter
2017-04-24  8:12     ` Linus Walleij
2017-04-24  9:14       ` Bough Chen
2017-06-15 11:38         ` Adrian Hunter
2017-06-15 11:49           ` Bough Chen
2017-06-20  8:01             ` Bough Chen
2017-06-20  9:04               ` Adrian Hunter
2017-07-04 10:21                 ` Bough Chen
2017-07-06 10:48                   ` Adrian Hunter
2017-04-25 13:28       ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489408613-26915-9-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Yuliy.Izrailov@sandisk.com \
    --cc=alex.lemberg@sandisk.com \
    --cc=asutoshd@codeaurora.org \
    --cc=david.griego@linaro.org \
    --cc=dongas86@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=kdorfman@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mateusz.nowak@intel.com \
    --cc=riteshh@codeaurora.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox