From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Amarinder Bindra <a-bindra@ti.com>
Cc: Chris Ball <chris@printf.net>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: host: MMC_SH_MMCIF should depend on HAS_DMA
Date: Fri, 21 Feb 2014 21:26:59 +0100 [thread overview]
Message-ID: <1491186.LfrL8k5P1F@avalon> (raw)
In-Reply-To: <1393012371-22320-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
Thank you for the patches.
On Friday 21 February 2014 20:52:50 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `sh_mmcif_start_dma_tx':
> sh_mmcif.c:(.text+0x5a3286): undefined reference to `dma_map_sg'
> drivers/built-in.o: In function `sh_mmcif_start_dma_rx':
> sh_mmcif.c:(.text+0x5a33fc): undefined reference to `dma_map_sg'
> drivers/built-in.o: In function `sh_mmcif_end_cmd':
> sh_mmcif.c:(.text+0x5a3668): undefined reference to `dma_unmap_sg'
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
For both,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 1384f67abe21..bfe2133d0b9c 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -611,7 +611,7 @@ config MMC_DW_PCI
>
> config MMC_SH_MMCIF
> tristate "SuperH Internal MMCIF support"
> - depends on MMC_BLOCK
> + depends on MMC_BLOCK && HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> This selects the MMC Host Interface controller (MMCIF).
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-02-21 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 19:52 [PATCH 1/2] mmc: host: MMC_SH_MMCIF should depend on HAS_DMA Geert Uytterhoeven
2014-02-21 19:52 ` [PATCH 2/2] mmc: host: MMC_OMAP_HS " Geert Uytterhoeven
2014-02-21 20:26 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491186.LfrL8k5P1F@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a-bindra@ti.com \
--cc=chris@printf.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).