Re: [PATCH V4 00/11] mmc: Add Command Queue support

Shawn Lin
2017-07-31T07:13:18Z

Hi

On 2017/7/31 14:54, Adrian Hunter wrote:
> On 25/07/17 03:34, Shawn Lin wrote:
>> Hi
>>
>> On 2017/7/24 18:09, Adrian Hunter wrote:
>>> On 24/07/17 12:17, Shawn Lin wrote:
>>>> Hi Adrian,
>>>>
>>>> On 2017/7/21 17:49, Adrian Hunter wrote:
>>>>> Hi
>>>>>
>>>>> Here is V4 of the hardware command queue patches without the software
>>>>> command queue patches.
>>>>>
>>>>
>>>> I see this log for the reboot test last weekend. One of my boards
>>>> seems to easily trigger this WARN_ONCE.
>>>>
>>>> [ 10.012778] mmc1: cqhci: spurious TCN for tag 31
>>>
>>> Tag 31 is DCMD. DCMD can be problematic which is one of the reasons it is
>>> optional. In this case it looks like you are getting a TCN before the DCMD
>>> is actually finished. You should be able to see if that is the case by
>>
>> yes, it is that case you refer to.
>>
>>> dumping the registers when it happens, although you will need to stop
>>> messages going to the console because that will be too slow.
>>
>> okay, I will remove DCMD caps for the test and see what we could
>> do to make DCMD more robust later.
>>
>
> Are you going to do more review of CQ?

Yes, I am reviewing it :)

And I have been testing it for more than one week for various stress
test and all things work fine except for the the spurious TCN for DCMD.
But that seems much likely to be the IP relevant, so I won't going to
add caps for DCMD for my controller right now, until I find the root
cause.

>
>
>
>