Re: [PATCH V4 00/11] mmc: Add Command Queue support

Shawn Lin
2017-08-03T00:50:27Z

Hi Adrian,

On 2017/7/21 17:49, Adrian Hunter wrote:
> Hi
>
> Here is V4 of the hardware command queue patches without the software
> command queue patches.
>
>

After looking into the changes in details for some days, it looks
awsome to me. And my boards are still alive after more than one week's
test. Can't wait to enable it for 4.14 :)

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Tested-by: Shawn Lin <shawn.lin@rock-chips.com>

> Changes since V3:
> Adjusted ...blk_end_request...() for new block status codes
> Fixed CQHCI transaction descriptor for "no DCMD" case
>
> Changes since V2:
> Dropped patches that have been applied.
> Re-based
> Added "mmc: sdhci-pci: Add CQHCI support for Intel GLK"
>
> Changes since V1:
>
> "Share mmc request array between partitions" is dependent
> on changes in "Introduce queue semantics", so added that
> and block fixes:
>
> Added "Fix is_waiting_last_req set incorrectly"
> Added "Fix cmd error reset failure path"
> Added "Use local var for mqrq_cur"
> Added "Introduce queue semantics"
>
> Changes since RFC:
>
> Re-based on next.
> Added comment about command queue priority.
> Added some acks and reviews.
>
>
> Adrian Hunter (10):
> mmc: core: Add mmc_retune_hold_now()
> mmc: core: Add members to mmc_request and mmc_data for CQE's
> mmc: host: Add CQE interface
> mmc: core: Turn off CQE before sending commands
> mmc: core: Add support for handling CQE requests
> mmc: mmc: Enable Command Queuing
> mmc: mmc: Enable CQE's
> mmc: block: Prepare CQE data
> mmc: block: Add CQE support
> mmc: sdhci-pci: Add CQHCI support for Intel GLK
>
> Venkat Gopalakrishnan (1):
> mmc: cqhci: support for command queue enabled host
>
> drivers/mmc/core/block.c | 240 +++++++-
> drivers/mmc/core/block.h | 7 +
> drivers/mmc/core/bus.c | 7 +
> drivers/mmc/core/core.c | 156 ++++-
> drivers/mmc/core/host.c | 6 +
> drivers/mmc/core/host.h | 1 +
> drivers/mmc/core/mmc.c | 30 +-
> drivers/mmc/core/queue.c | 273 ++++++++-
> drivers/mmc/core/queue.h | 42 +-
> drivers/mmc/host/Kconfig | 14 +
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/cqhci.c | 1146 +++++++++++++++++++++++++++++++++++++
> drivers/mmc/host/cqhci.h | 240 ++++++++
> drivers/mmc/host/sdhci-pci-core.c | 153 ++++-
> include/linux/mmc/core.h | 18 +-
> include/linux/mmc/host.h | 24 +
> include/trace/events/mmc.h | 36 +-
> 17 files changed, 2354 insertions(+), 40 deletions(-)
> create mode 100644 drivers/mmc/host/cqhci.c
> create mode 100644 drivers/mmc/host/cqhci.h
>
>
> Regards
> Adrian
>
>
>