* [PATCH] omap/hsmmc: constify dev_pm_ops
@ 2017-08-08 11:14 Doug Wilson
2017-08-08 11:34 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Doug Wilson @ 2017-08-08 11:14 UTC (permalink / raw)
To: linux-omap; +Cc: linux-mmc, linux-kernel, Doug Wilson, Doug Wilson
dev_pm_ops is not supposed to change at runtime. Marking it
constant.
Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
---
drivers/mmc/host/omap_hsmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 04ff3c9..a280c7f 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
return 0;
}
-static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
+static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
.runtime_suspend = omap_hsmmc_runtime_suspend,
.runtime_resume = omap_hsmmc_runtime_resume,
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] omap/hsmmc: constify dev_pm_ops
2017-08-08 11:14 [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson
@ 2017-08-08 11:34 ` Ulf Hansson
2017-08-08 11:39 ` Doug Wilson
0 siblings, 1 reply; 5+ messages in thread
From: Ulf Hansson @ 2017-08-08 11:34 UTC (permalink / raw)
To: Doug Wilson
Cc: linux-omap, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, Doug Wilson
On 8 August 2017 at 13:14, Doug Wilson <doug.lkml@gmail.com> wrote:
> dev_pm_ops is not supposed to change at runtime. Marking it
> constant.
>
> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
This doesn't apply on my next branch, please re-base it.
Kind regards
Uffe
> ---
> drivers/mmc/host/omap_hsmmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 04ff3c9..a280c7f 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
> .runtime_suspend = omap_hsmmc_runtime_suspend,
> .runtime_resume = omap_hsmmc_runtime_resume,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] omap/hsmmc: constify dev_pm_ops
2017-08-08 11:34 ` Ulf Hansson
@ 2017-08-08 11:39 ` Doug Wilson
2017-08-08 11:45 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Doug Wilson @ 2017-08-08 11:39 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-omap, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, Doug Wilson
>>
>> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
>
> This doesn't apply on my next branch, please re-base it.
is this your next-branch :kernel/git/ulfh/mmc.git ?
- Doug
>>
>> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>> SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
>> .runtime_suspend = omap_hsmmc_runtime_suspend,
>> .runtime_resume = omap_hsmmc_runtime_resume,
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-08 11:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 11:14 [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson
2017-08-08 11:34 ` Ulf Hansson
2017-08-08 11:39 ` Doug Wilson
2017-08-08 11:45 ` Ulf Hansson
2017-08-08 11:47 ` Doug Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox