linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	linux-block <linux-block@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Bough Chen <haibo.chen@nxp.com>,
	Alex Lemberg <alex.lemberg@sandisk.com>,
	Mateusz Nowak <mateusz.nowak@intel.com>,
	Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Dong Aisheng <dongas86@gmail.com>,
	Das Asutosh <asutoshd@codeaurora.org>,
	Zhangfei Gao <zhangfei.gao@gmail.com>,
	Sahitya Tummala <stummala@codeaurora.org>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH V9 06/15] mmc: block: Use local variables in mmc_blk_data_prep()
Date: Fri, 22 Sep 2017 15:36:55 +0300	[thread overview]
Message-ID: <1506083824-4024-7-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1506083824-4024-1-git-send-email-adrian.hunter@intel.com>

Use local variables in mmc_blk_data_prep() in preparation for adding CQE
support which doesn't use the output variables.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/core/block.c | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 41e7124b8679..a52653ce2d3a 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1575,21 +1575,22 @@ static enum mmc_blk_status mmc_blk_err_check(struct mmc_card *card,
 }
 
 static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
-			      int disable_multi, bool *do_rel_wr,
-			      bool *do_data_tag)
+			      int disable_multi, bool *do_rel_wr_p,
+			      bool *do_data_tag_p)
 {
 	struct mmc_blk_data *md = mq->blkdata;
 	struct mmc_card *card = md->queue.card;
 	struct mmc_blk_request *brq = &mqrq->brq;
 	struct request *req = mmc_queue_req_to_req(mqrq);
+	bool do_rel_wr, do_data_tag;
 
 	/*
 	 * Reliable writes are used to implement Forced Unit Access and
 	 * are supported only on MMCs.
 	 */
-	*do_rel_wr = (req->cmd_flags & REQ_FUA) &&
-		     rq_data_dir(req) == WRITE &&
-		     (md->flags & MMC_BLK_REL_WR);
+	do_rel_wr = (req->cmd_flags & REQ_FUA) &&
+		    rq_data_dir(req) == WRITE &&
+		    (md->flags & MMC_BLK_REL_WR);
 
 	memset(brq, 0, sizeof(struct mmc_blk_request));
 
@@ -1637,18 +1638,18 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
 						brq->data.blocks);
 	}
 
-	if (*do_rel_wr)
+	if (do_rel_wr)
 		mmc_apply_rel_rw(brq, card, req);
 
 	/*
 	 * Data tag is used only during writing meta data to speed
 	 * up write and any subsequent read of this meta data
 	 */
-	*do_data_tag = card->ext_csd.data_tag_unit_size &&
-		       (req->cmd_flags & REQ_META) &&
-		       (rq_data_dir(req) == WRITE) &&
-		       ((brq->data.blocks * brq->data.blksz) >=
-			card->ext_csd.data_tag_unit_size);
+	do_data_tag = card->ext_csd.data_tag_unit_size &&
+		      (req->cmd_flags & REQ_META) &&
+		      (rq_data_dir(req) == WRITE) &&
+		      ((brq->data.blocks * brq->data.blksz) >=
+		       card->ext_csd.data_tag_unit_size);
 
 	mmc_set_data_timeout(&brq->data, card);
 
@@ -1675,6 +1676,12 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
 	}
 
 	mqrq->areq.mrq = &brq->mrq;
+
+	if (do_rel_wr_p)
+		*do_rel_wr_p = do_rel_wr;
+
+	if (do_data_tag_p)
+		*do_data_tag_p = do_data_tag;
 }
 
 static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
-- 
1.9.1

  parent reply	other threads:[~2017-09-22 12:36 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 12:36 [PATCH V9 00/15] mmc: Add Command Queue support Adrian Hunter
2017-09-22 12:36 ` [PATCH V9 01/15] mmc: core: Remove unnecessary host claim Adrian Hunter
2017-09-22 14:03   ` Linus Walleij
2017-09-22 12:36 ` [PATCH V9 02/15] mmc: core: Introduce host claiming by context Adrian Hunter
2017-09-22 12:36 ` [PATCH V9 03/15] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-09-26 15:31   ` Linus Walleij
2017-09-22 12:36 ` [PATCH V9 04/15] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-09-26 15:33   ` Linus Walleij
2017-09-22 12:36 ` [PATCH V9 05/15] mmc: mmc: Enable CQE's Adrian Hunter
2017-09-26 15:33   ` Linus Walleij
2017-09-22 12:36 ` Adrian Hunter [this message]
2017-09-26 15:34   ` [PATCH V9 06/15] mmc: block: Use local variables in mmc_blk_data_prep() Linus Walleij
2017-09-22 12:36 ` [PATCH V9 07/15] mmc: block: Prepare CQE data Adrian Hunter
2017-09-26 15:37   ` Linus Walleij
2017-09-22 12:36 ` [PATCH V9 08/15] mmc: block: Factor out mmc_setup_queue() Adrian Hunter
2017-09-26 15:38   ` Linus Walleij
2017-09-22 12:36 ` [PATCH V9 09/15] mmc: core: Add parameter use_blk_mq Adrian Hunter
2017-09-26 23:42   ` Linus Walleij
2017-09-27 12:02     ` Adrian Hunter
2017-09-27 19:49       ` Linus Walleij
2017-09-27 12:58     ` Avri Altman
2017-10-02  8:30   ` Ulf Hansson
2017-09-22 12:36 ` [PATCH V9 10/15] mmc: core: Export mmc_start_bkops() Adrian Hunter
2017-09-26 23:46   ` Linus Walleij
2017-09-22 12:37 ` [PATCH V9 11/15] mmc: core: Export mmc_start_request() Adrian Hunter
2017-09-26 23:47   ` Linus Walleij
2017-09-22 12:37 ` [PATCH V9 12/15] mmc: core: Export mmc_retune_hold_now() and mmc_retune_release() Adrian Hunter
2017-09-26 23:49   ` Linus Walleij
2017-10-02  8:30   ` Ulf Hansson
2017-09-22 12:37 ` [PATCH V9 13/15] mmc: block: Add CQE and blk-mq support Adrian Hunter
2017-10-02  8:32   ` Ulf Hansson
2017-10-06  8:03     ` Adrian Hunter
2017-10-04  7:39   ` Linus Walleij
2017-10-04  9:39     ` Bartlomiej Zolnierkiewicz
2017-10-04  9:48       ` Ulf Hansson
2017-10-05 10:55         ` Bartlomiej Zolnierkiewicz
2017-10-05 11:12           ` Ulf Hansson
2017-10-04 19:23       ` Hunter, Adrian
2017-10-05 12:00         ` Bartlomiej Zolnierkiewicz
2017-10-05 14:14           ` Bartlomiej Zolnierkiewicz
2017-10-04 13:27     ` Adrian Hunter
2017-10-05  8:59   ` [PATCH V10 " Adrian Hunter
2017-09-22 12:37 ` [PATCH V9 14/15] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-09-25  2:39   ` Bough Chen
2017-09-25  6:32     ` Adrian Hunter
2017-09-25  7:27   ` [PATCH V10 " Adrian Hunter
2017-09-22 12:37 ` [PATCH V9 15/15] mmc: sdhci-pci: Add CQHCI support for Intel GLK Adrian Hunter
2017-09-26 22:25 ` [PATCH V9 00/15] mmc: Add Command Queue support Ulf Hansson
2017-10-11 13:24   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506083824-4024-7-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Yuliy.Izrailov@sandisk.com \
    --cc=alex.lemberg@sandisk.com \
    --cc=asutoshd@codeaurora.org \
    --cc=dongas86@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=hch@lst.de \
    --cc=jh80.chung@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mateusz.nowak@intel.com \
    --cc=riteshh@codeaurora.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).