From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 07/15] mmc: sdhi: Enable driver compilation with COMPILE_TEST Date: Tue, 07 Jan 2014 16:10:37 +0100 Message-ID: <1526599.nZ6xaI3TN3@avalon> References: <1385515117-23664-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1385515117-23664-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <2090378.13zHUAnprd@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:41431 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbaAGPJ6 (ORCPT ); Tue, 7 Jan 2014 10:09:58 -0500 In-Reply-To: <2090378.13zHUAnprd@avalon> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Guennadi Liakhovetski , Ian Molton , linux-mmc@vger.kernel.org Hi Chris, On Wednesday 11 December 2013 13:53:21 Laurent Pinchart wrote: > Hi Chris, > > Could you please pick this patch (and patch 08/15 in the same series) up for > v3.14 ? Ping ? > On Wednesday 27 November 2013 02:18:29 Laurent Pinchart wrote: > > This helps increasing build testing coverage. > > > > The driver doesn't compile on (at least) x86 due (possibly among others) > > to missing readsw/writesw I/O accessors, restrict compilation to SUPERH > > or ARM. > > > > Whether the CTL_DMA_ENABLE register is part of the standard TMIO > > controller or is Renesas-specific is unknown and impossible to test as > > we have no current or planned TMIO DMA users other than SUPERH and > > ARCH_SHMOBILE. Writing to the register is thus conditionally compiled > > for SUPERH and ARCH_SHMOBILE only. Adding ARCH_SHMOBILE_MULTI to the > > list would extend this to multiarch kernels, but would break the driver > > for non-shmobile platforms if the register is Renesas-specific. We can > > thus get rid of the conditional compilation completely without > > introducing any further issue, and let future non-Renesas users deal > > with the situation if it turns out to be a the problem. > > > > Cc: Chris Ball > > Cc: Guennadi Liakhovetski > > Cc: Ian Molton > > Cc: linux-mmc@vger.kernel.org > > Signed-off-by: Laurent Pinchart > > > > Acked-by: Simon Horman > > --- > > > > drivers/mmc/host/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > > index 7fc5099..ca1315e 100644 > > --- a/drivers/mmc/host/Kconfig > > +++ b/drivers/mmc/host/Kconfig > > @@ -479,7 +479,8 @@ config MMC_TMIO > > > > config MMC_SDHI > > > > tristate "SH-Mobile SDHI SD/SDIO controller support" > > > > - depends on SUPERH || ARCH_SHMOBILE > > + depends on SUPERH || ARM > > + depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST > > > > select MMC_TMIO_CORE > > help > > > > This provides support for the SDHI SD/SDIO controller found in -- Regards, Laurent Pinchart