Re: [PATCH V9 3/3] mmc: tegra: HW Command Queue Support for Tegra SDMMC

Adrian Hunter
2019-01-21T12:52:59Z

On 21/01/19 12:44 PM, Thierry Reding wrote:
> On Tue, Jan 15, 2019 at 11:03:52AM -0800, Sowjanya Komatineni wrote:
>> This patch adds HW Command Queue for supported Tegra SDMMC
>> controllers.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> drivers/mmc/host/Kconfig | 1 +
>> drivers/mmc/host/sdhci-tegra.c | 117 +++++++++++++++++++++++++++++++++++++++--
>> drivers/mmc/host/sdhci.c | 9 +++-
>> drivers/mmc/host/sdhci.h | 2 +
>> 4 files changed, 124 insertions(+), 5 deletions(-)
>
> Looks good to me. It might be worth splitting off the SDHCI core changes
> into a separate patch, but that's for Adrian and Ulf to decide. From a

Yes that would be better. Otherwise seems fine.

> Tegra point of view:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
>