[PATCH] mmc: sunxi: change controller error info to debug level

[PATCH] mmc: sunxi: change controller error info to debug level

[Icenowy Zheng]

The controller's errors are usually normal (for example, for MMC or SDIO
cards, some errors are expected to happen; and for boards without a
dedicated card detect pin the error info will even flood console and
hide other normal messages) and hard to understand.

Change their print level to debug, thus it won't be shown to generic
users.

Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---
 drivers/mmc/host/sunxi-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 6ffcd2838272..0391c62cc99f 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
 				      cmd->opcode == SD_IO_RW_DIRECT))
 		return;
 
-	dev_err(mmc_dev(host->mmc),
+	dev_dbg(mmc_dev(host->mmc),
 		"smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
 		host->mmc->index, cmd->opcode,
 		data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
-- 
2.12.0

Re: [PATCH] mmc: sunxi: change controller error info to debug level

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

On Thu, Mar 16, 2017 at 09:29:03PM +0800, Icenowy Zheng wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
> 
> Change their print level to debug, thus it won't be shown to generic
> users.
> 
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>

Acked-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH] mmc: sunxi: change controller error info to debug level

[Ulf Hansson]

On 16 March 2017 at 14:29, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
> The controller's errors are usually normal (for example, for MMC or SDIO
> cards, some errors are expected to happen; and for boards without a
> dedicated card detect pin the error info will even flood console and
> hide other normal messages) and hard to understand.
>
> Change their print level to debug, thus it won't be shown to generic
> users.
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>

For some reason this change didn't enter the mmc patchtracker. However
I have picked it up for next anyway.

Thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sunxi-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
> index 6ffcd2838272..0391c62cc99f 100644
> --- a/drivers/mmc/host/sunxi-mmc.c
> +++ b/drivers/mmc/host/sunxi-mmc.c
> @@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
>                                       cmd->opcode == SD_IO_RW_DIRECT))
>                 return;
>
> -       dev_err(mmc_dev(host->mmc),
> +       dev_dbg(mmc_dev(host->mmc),
>                 "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
>                 host->mmc->index, cmd->opcode,
>                 data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
> --
> 2.12.0
>

Re: [PATCH] mmc: sunxi: change controller error info to debug level

[Icenowy Zheng]

24.03.2017, 15:46, "Ulf Hansson" <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>:
> On 16 March 2017 at 14:29, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
>>  The controller's errors are usually normal (for example, for MMC or SDIO
>>  cards, some errors are expected to happen; and for boards without a
>>  dedicated card detect pin the error info will even flood console and
>>  hide other normal messages) and hard to understand.
>>
>>  Change their print level to debug, thus it won't be shown to generic
>>  users.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>
> For some reason this change didn't enter the mmc patchtracker. However
> I have picked it up for next anyway.

Thanks!

Maybe it's because of the e-mail provider chosen by AOSC (Yandex.Mail).

Sorry. I will try to ask for a migration to other e-mail provider.

>
> Thanks!
>
> Kind regards
> Uffe
>
>>  ---
>>   drivers/mmc/host/sunxi-mmc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>  diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
>>  index 6ffcd2838272..0391c62cc99f 100644
>>  --- a/drivers/mmc/host/sunxi-mmc.c
>>  +++ b/drivers/mmc/host/sunxi-mmc.c
>>  @@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
>>                                        cmd->opcode == SD_IO_RW_DIRECT))
>>                  return;
>>
>>  - dev_err(mmc_dev(host->mmc),
>>  + dev_dbg(mmc_dev(host->mmc),
>>                  "smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
>>                  host->mmc->index, cmd->opcode,
>>                  data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
>>  --
>>  2.12.0

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.