From: Adrian Hunter <adrian.hunter@intel.com>
To: Alamy Liu <alamy.liu@gmail.com>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: cqhci: data size depending on queue depth
Date: Thu, 31 Jan 2019 11:53:11 +0200 [thread overview]
Message-ID: <16f9aaea-2e6c-a754-5029-dfbc1a2edba7@intel.com> (raw)
In-Reply-To: <20190115191356.32714-1-alamy.liu@gmail.com>
On 15/01/19 9:13 PM, Alamy Liu wrote:
> CQE_DCMD is not necessary to be enabled when CQE is enabled.
> (Software could halt CQE to send command, or via DCMD)
>
> In the case that CQE_DCMD is not enabled, it still needs to allocate
> space for data transfer. For instance:
> CQE_DCMD is enabled: 32 slots space
> CQE_DCMD is disabled: 31 slots space (is good enough)
Is that the right way around?
If DCMD is enabled then we need 31 slots for data transfer and 1 for DCMD.
If DCMD is disabled then we need 32 slots for data transfer.
>
> Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 4cc7863c13..974997b6cb 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -202,7 +202,7 @@ static int cqhci_host_alloc_tdl(struct cqhci_host *cq_host)
> cq_host->desc_size = cq_host->slot_sz * cq_host->num_slots;
>
> cq_host->data_size = cq_host->trans_desc_len * cq_host->mmc->max_segs *
> - (cq_host->num_slots - 1);
> + cq_host->mmc->cqe_qdepth;
So there is not enough being allocated for the !(mmc->caps2 &
MMC_CAP2_CQE_DCMD) case, which means this is a fix? In that case, please
add a fixes tag, cc stable, and make the commit message clear that this is a
fix.
>
> pr_debug("%s: cqhci: desc_size: %zu data_sz: %zu slot-sz: %d\n",
> mmc_hostname(cq_host->mmc), cq_host->desc_size, cq_host->data_size,
>
prev parent reply other threads:[~2019-01-31 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:13 [PATCH] mmc: cqhci: data size depending on queue depth Alamy Liu
2019-01-31 9:53 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f9aaea-2e6c-a754-5029-dfbc1a2edba7@intel.com \
--to=adrian.hunter@intel.com \
--cc=alamy.liu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox