From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] mmc: sh_mmcif: Silence DMA slave ID compile warnings on 64-bit
Date: Thu, 20 Aug 2015 15:29:47 +0200 [thread overview]
Message-ID: <1781695.TNL8ksnpjB@wuerfel> (raw)
In-Reply-To: <CAMuHMdVksvUvrzuPH4WqLDxLzpxGDauWW2GYi=ayzyzGmN5R=g@mail.gmail.com>
On Monday 17 August 2015 14:17:25 Geert Uytterhoeven wrote:
> >> This will break out-of-tree boards at compile-time though. Given the limited
> >> number of wired up DMA channels under arch/sh/, they may actually be
> >> more in use out-of-tree than in-tree?
> >>
> >> Alternatively, perhaps we should just drop pdata DMA configuration from
> >> some drivers?
> >
> > I think that would be helpful, but it would not work for this driver as
> > long as we keep arch/sh/boards/board-sh7757lcr.c in the kernel.
>
> No, not for this driver.
>
> But there are several drivers (spi-rspi, spi-sh-msiof, sh-sci, sh_flctl) that
> have .slave*id* fields in platform data, but no platform code ever sets them.
> Despite platform code that fills in SHDMA_SLAVE_* values in sh_dmae_chan.
> These don't work anyway, and I don't think anyone is interested in fixing that.
Right, removing pdata support for those would be a useful cleanup.
Arnd
next prev parent reply other threads:[~2015-08-20 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 12:48 [PATCH] mmc: sh_mmcif: Silence DMA slave ID compile warnings on 64-bit Geert Uytterhoeven
2015-08-12 14:50 ` Arnd Bergmann
2015-08-12 15:13 ` Geert Uytterhoeven
2015-08-15 20:26 ` Arnd Bergmann
2015-08-17 12:17 ` Geert Uytterhoeven
2015-08-20 13:29 ` Arnd Bergmann [this message]
2015-08-17 13:02 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1781695.TNL8ksnpjB@wuerfel \
--to=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox