From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 06/16] mmc: core: replace waitqueue with worker Date: Tue, 14 Mar 2017 08:52:40 -0600 Message-ID: <17cd4927-eb41-8eb3-9c06-ad7f4016a867@kernel.dk> References: <20170209153403.9730-1-linus.walleij@linaro.org> <20170209153403.9730-7-linus.walleij@linaro.org> <00989e26-cdb9-48d7-2e46-ae6ef66e59a7@intel.com> <3fc89f9f-fbcf-113d-3644-b6c9dae003f0@intel.com> <8f1f3d4c-410c-2632-c776-4ced363bdb0d@kernel.dk> <97f2a4ea-0802-9f23-6ac7-b9d6c6afbfcc@kernel.dk> <20170314144357.GA31043@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-it0-f48.google.com ([209.85.214.48]:37584 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbdCNOwo (ORCPT ); Tue, 14 Mar 2017 10:52:44 -0400 Received: by mail-it0-f48.google.com with SMTP id g138so922091itb.0 for ; Tue, 14 Mar 2017 07:52:43 -0700 (PDT) In-Reply-To: <20170314144357.GA31043@lst.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Christoph Hellwig Cc: Adrian Hunter , Linus Walleij , "linux-mmc@vger.kernel.org" , Ulf Hansson , Paolo Valente , Chunyan Zhang , Baolin Wang , linux-block@vger.kernel.org, Arnd Bergmann On 03/14/2017 08:43 AM, Christoph Hellwig wrote: > On Tue, Mar 14, 2017 at 08:36:26AM -0600, Jens Axboe wrote: >> There's one case that doesn't look like it was converted properly, but >> that's a mistake. The general insert-and-run cases run inline if we can, >> but the direct-issue needs a fixup, see below. > > Note that blk_mq_try_issue_directly is only called for the multiple > hardware queue case, so MMC would not hit it. Right, which is why I said that the general case works fine, it's only the explicit issue-direct that currently does not. Not by design, just an error. -- Jens Axboe