From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Reichl Subject: Re: [PATCH] ARM: dts: exynos: Fix invalid maximum voltage for buck9 supplying SD card Date: Fri, 25 Mar 2016 08:14:15 +0100 Message-ID: <1809671.FobX8lDEN5@dell2.five-lan.de> References: <1458807125-13580-1-git-send-email-k.kozlowski@samsung.com> <56F4D070.4020403@osg.samsung.com> Reply-To: m.reichl@fivetechno.de Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <56F4D070.4020403@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Ulf Hansson , Mark Brown , Ivaylo Dimitrov List-Id: linux-mmc@vger.kernel.org Hi Javier, Am Freitag, 25. M=C3=A4rz 2016, 02:45:20 schrieb Javier Martinez Canill= as: > Hello Krzysztof, >=20 > On 03/24/2016 05:12 AM, Krzysztof Kozlowski wrote: > > The buck9 regulator of S2MPS11 PMIC had incorrect maximum voltage - > > lower by 5 mV than specified by datasheet. This buck9 provides powe= r to > > other regulators, including LDO13 and LDO19 which supply the MMC2 (= SD > > card). > >=20 > > When constraints were applied, the depending regulators were not > > providing enough power, leading to SD card detection errors: > > mmc1: card never left busy state > > mmc1: error -110 whilst initialising SD card > >=20 > > Fixes: 86a2d2ac5e5d ("ARM: dts: Add dts file for Odroid XU3 board") > > Signed-off-by: Krzysztof Kozlowski > >=20 > > --- > >=20 > > The issue can be reproduced on next-20160324 with > > bae4fdc88d7f7dda1 (regulator: core: Ensure we are at least in bound= s for our constraints). > > --- > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/a= rch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > index 1bd507bfa750..82b2ba632cf6 100644 > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > @@ -299,7 +299,7 @@ > > buck9_reg: BUCK9 { > > regulator-name =3D "vdd_2.8v_ldo"; > > regulator-min-microvolt =3D <3000000>; > > - regulator-max-microvolt =3D <3750000>; > > + regulator-max-microvolt =3D <3755000>; > > regulator-always-on; > > regulator-boot-on; > > }; > >=20 >=20 > I tested next-20160324 + $SUBJECT on an Odroid XU4 (with exynos_defco= nfig) > and while it's true that the patch makes the SD card error to go away= , I see > that the s2mps11 regulator driver fails to probe due an -EINVAL being= return > by machine_constraints_voltage() -> _regulator_do_set_voltage(): >=20 > [ 1.710300] vdd_2.8v_ldo: failed to apply 3755000-3755000uV constr= aint(-22) > [ 1.716387] s2mps11-pmic s2mps11-regulator: regulator init failed = for 46 > [ 1.734878] s2mps11-pmic: probe of s2mps11-regulator failed with e= rror -22 >=20 > I wonder how neither Markus nor you saw this issue when testing so ma= ybe I'm > doing something wrong? Since AFAICT it's only working because the dri= ver fails > to probe so the same effect can be achieved disabling CONFIG_REGULATO= R_S2MPS11. >=20 > Best regards, >=20 My first test yesterday was with next-20160324 + $SUBJECT, too, and I e= ncountered the same error of the regulator system as you. As with next-20160324 I could not get the ethernet chip running (with o= r without $SUBJECT) I switched back to next-20160323 + $SUBJECT and posted the result above. Regards, -- Markus=20