* [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT
@ 2025-08-28 13:17 Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
Hi,
The following patches add a few peripheral DT nodes and related pin/gpio
nodes for Raspberry Pi 5.
- Patch 1: Amend the bindings to avoid DT compiler warnings.
- Patch 2: Adds core pinctrl nodes and defines SD pins as a first appliance
for the pinctrl.
- Patch 3: Wires the gpio-key for power button and related gpio controller.
- Patch 4: Adds DT node for WiFi.
- Patch 5: Adds Bluetooth DT node.
All comments and suggestions are welcome!
Happy hacking!
Ivan and Andrea
CHANGES in V2:
--- DTS ---
- bcm2712.dtsi: added a proper clocks node to the uarta serial
in order to replace the legacy clock-frequency property. As
a result, the following patch from the previous patchset
has been dropped since it's now useless:
"dt-bindings: serial: Add clock-frequency property as an alternative to clocks"
Andrea della Porta (1):
dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI
controller
Ivan T. Ivanov (4):
arm64: dts: broadcom: bcm2712: Add pin controller nodes
arm64: dts: broadcom: bcm2712: Add one more GPIO node
arm64: dts: broadcom: bcm2712: Add second SDHCI controller node
arm64: dts: broadcom: bcm2712: Add UARTA controller node
.../bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +-
.../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 133 ++++++++++++++++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 55 ++++++++
3 files changed, 189 insertions(+), 1 deletion(-)
--
2.35.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
@ 2025-08-28 13:17 ` Andrea della Porta
2025-08-29 18:01 ` Rob Herring (Arm)
2025-08-28 13:17 ` [PATCH v2 2/5] arm64: dts: broadcom: bcm2712: Add pin controller nodes Andrea della Porta
` (4 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
The Broadcom BRCMSTB SDHCI Controller device supports Common
properties in terms of Capabilities.
Reference sdhci-common schema instead of mmc-controller in order
for capabilities to be specified in DT nodes avoiding warnings
from the DT compiler.
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
index eee6be7a7867..493655a38b37 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -61,7 +61,7 @@ properties:
description: Specifies that controller should use auto CMD12
allOf:
- - $ref: mmc-controller.yaml#
+ - $ref: sdhci-common.yaml#
- if:
properties:
clock-names:
--
2.35.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/5] arm64: dts: broadcom: bcm2712: Add pin controller nodes
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
@ 2025-08-28 13:17 ` Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 3/5] arm64: dts: broadcom: bcm2712: Add one more GPIO node Andrea della Porta
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
From: "Ivan T. Ivanov" <iivanov@suse.de>
Add pin-control devicetree nodes and used them to
explicitly define uSD card interface pin configuration.
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
.../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 18 ++++++++++++++++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 10 ++++++++++
2 files changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
index 6ea3c102e0d6..6091a1ff365c 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
@@ -53,6 +53,21 @@ sd_vcc_reg: sd-vcc-reg {
};
};
+&pinctrl {
+ emmc_sd_default: emmc-sd-default-state {
+ pins = "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat3";
+ bias-pull-up;
+ };
+};
+
+&pinctrl_aon {
+ emmc_aon_cd_default: emmc-aon-cd-default-state {
+ function = "sd_card_g";
+ pins = "aon_gpio5";
+ bias-pull-up;
+ };
+};
+
/* The Debug UART, on Rpi5 it's on JST-SH 1.0mm 3-pin connector
* labeled "UART", i.e. the interface with the system console.
*/
@@ -62,12 +77,15 @@ &uart10 {
/* SDIO1 is used to drive the SD card */
&sdio1 {
+ pinctrl-0 = <&emmc_sd_default>, <&emmc_aon_cd_default>;
+ pinctrl-names = "default";
vqmmc-supply = <&sd_io_1v8_reg>;
vmmc-supply = <&sd_vcc_reg>;
bus-width = <4>;
sd-uhs-sdr50;
sd-uhs-ddr50;
sd-uhs-sdr104;
+ cd-gpios = <&gio_aon 5 GPIO_ACTIVE_LOW>;
};
&soc {
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index 0a9212d3106f..8a517261841d 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -243,6 +243,16 @@ uart10: serial@7d001000 {
status = "disabled";
};
+ pinctrl: pinctrl@7d504100 {
+ compatible = "brcm,bcm2712c0-pinctrl";
+ reg = <0x7d504100 0x30>;
+ };
+
+ pinctrl_aon: pinctrl@7d510700 {
+ compatible = "brcm,bcm2712c0-aon-pinctrl";
+ reg = <0x7d510700 0x20>;
+ };
+
interrupt-controller@7d517000 {
compatible = "brcm,bcm7271-l2-intc";
reg = <0x7d517000 0x10>;
--
2.35.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/5] arm64: dts: broadcom: bcm2712: Add one more GPIO node
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 2/5] arm64: dts: broadcom: bcm2712: Add pin controller nodes Andrea della Porta
@ 2025-08-28 13:17 ` Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 4/5] arm64: dts: broadcom: bcm2712: Add second SDHCI controller node Andrea della Porta
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
From: "Ivan T. Ivanov" <iivanov@suse.de>
Add GPIO and related interrupt controller nodes and wire one
of the lines to power button.
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
.../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 21 +++++++++++++++++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 12 +++++++++++
2 files changed, 33 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
index 6091a1ff365c..f0883c903527 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
@@ -2,6 +2,7 @@
/dts-v1/;
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
#include "bcm2712.dtsi"
/ {
@@ -29,6 +30,20 @@ memory@0 {
reg = <0 0 0 0x28000000>;
};
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwr_button_default>;
+ status = "okay";
+
+ power_button: power-button {
+ label = "pwr_button";
+ linux,code = <KEY_POWER>;
+ gpios = <&gio 20 GPIO_ACTIVE_LOW>;
+ debounce-interval = <50>;
+ };
+ };
+
sd_io_1v8_reg: sd-io-1v8-reg {
compatible = "regulator-gpio";
regulator-name = "vdd-sd-io";
@@ -58,6 +73,12 @@ emmc_sd_default: emmc-sd-default-state {
pins = "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat3";
bias-pull-up;
};
+
+ pwr_button_default: pwr-button-default-state {
+ function = "gpio";
+ pins = "gpio20";
+ bias-pull-up;
+ };
};
&pinctrl_aon {
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index 8a517261841d..f70ec8d3dc4d 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -248,6 +248,18 @@ pinctrl: pinctrl@7d504100 {
reg = <0x7d504100 0x30>;
};
+ gio: gpio@7d508500 {
+ compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
+ reg = <0x7d508500 0x40>;
+ interrupt-parent = <&main_irq>;
+ interrupts = <0>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ brcm,gpio-bank-widths = <32 22>;
+ };
+
pinctrl_aon: pinctrl@7d510700 {
compatible = "brcm,bcm2712c0-aon-pinctrl";
reg = <0x7d510700 0x20>;
--
2.35.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 4/5] arm64: dts: broadcom: bcm2712: Add second SDHCI controller node
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
` (2 preceding siblings ...)
2025-08-28 13:17 ` [PATCH v2 3/5] arm64: dts: broadcom: bcm2712: Add one more GPIO node Andrea della Porta
@ 2025-08-28 13:17 ` Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 5/5] arm64: dts: broadcom: bcm2712: Add UARTA " Andrea della Porta
2025-08-28 20:31 ` [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Rob Herring (Arm)
5 siblings, 0 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
From: "Ivan T. Ivanov" <iivanov@suse.de>
Add SDIO2 node. On RPi5 it is connected to WiFi chip.
Add related pin, gpio and regulator definitions and
add WiFi node. With this and firmware already provided by
distributions, at least on openSUSE Tumbleweed, this is
sufficient to make WiFi operational on RPi5 \o/.
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
.../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 52 +++++++++++++++++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 15 ++++++
2 files changed, 67 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
index f0883c903527..411b58c1dddf 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
@@ -66,6 +66,18 @@ sd_vcc_reg: sd-vcc-reg {
enable-active-high;
gpios = <&gio_aon 4 GPIO_ACTIVE_HIGH>;
};
+
+ wl_on_reg: wl-on-reg {
+ compatible = "regulator-fixed";
+ regulator-name = "wl-on-regulator";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ pinctrl-0 = <&wl_on_default>;
+ pinctrl-names = "default";
+ gpio = <&gio 28 GPIO_ACTIVE_HIGH>;
+ startup-delay-us = <150000>;
+ enable-active-high;
+ };
};
&pinctrl {
@@ -79,6 +91,29 @@ pwr_button_default: pwr-button-default-state {
pins = "gpio20";
bias-pull-up;
};
+
+ sdio2_30_default: sdio2-30-default-state {
+ clk-pins {
+ function = "sd2";
+ pins = "gpio30";
+ bias-disable;
+ };
+ cmd-pins {
+ function = "sd2";
+ pins = "gpio31";
+ bias-pull-up;
+ };
+ dat-pins {
+ function = "sd2";
+ pins = "gpio32", "gpio33", "gpio34", "gpio35";
+ bias-pull-up;
+ };
+ };
+
+ wl_on_default: wl-on-default-state {
+ function = "gpio";
+ pins = "gpio28";
+ };
};
&pinctrl_aon {
@@ -109,6 +144,23 @@ &sdio1 {
cd-gpios = <&gio_aon 5 GPIO_ACTIVE_LOW>;
};
+&sdio2 {
+ pinctrl-0 = <&sdio2_30_default>;
+ pinctrl-names = "default";
+ bus-width = <4>;
+ vmmc-supply = <&wl_on_reg>;
+ sd-uhs-ddr50;
+ non-removable;
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wifi: wifi@1 {
+ reg = <1>;
+ compatible = "brcm,bcm4329-fmac";
+ };
+};
+
&soc {
firmware: firmware {
compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index f70ec8d3dc4d..871537366e96 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -285,6 +285,21 @@ gio_aon: gpio@7d517c00 {
*/
};
+ sdio2: mmc@1100000 {
+ compatible = "brcm,bcm2712-sdhci",
+ "brcm,sdhci-brcmstb";
+ reg = <0x01100000 0x260>,
+ <0x01100400 0x200>;
+ reg-names = "host", "cfg";
+ interrupts = <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk_emmc2>;
+ clock-names = "sw_sdio";
+ sdhci-caps-mask = <0x0000C000 0x0>;
+ sdhci-caps = <0x0 0x0>;
+ mmc-ddr-3_3v;
+ status = "disabled";
+ };
+
gicv2: interrupt-controller@7fff9000 {
compatible = "arm,gic-400";
reg = <0x7fff9000 0x1000>,
--
2.35.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 5/5] arm64: dts: broadcom: bcm2712: Add UARTA controller node
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
` (3 preceding siblings ...)
2025-08-28 13:17 ` [PATCH v2 4/5] arm64: dts: broadcom: bcm2712: Add second SDHCI controller node Andrea della Porta
@ 2025-08-28 13:17 ` Andrea della Porta
2025-08-28 20:31 ` [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Rob Herring (Arm)
5 siblings, 0 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-28 13:17 UTC (permalink / raw)
To: linus.walleij, robh, krzk+dt, conor+dt, florian.fainelli,
wahrenst, linux-gpio, devicetree, linux-arm-kernel,
Catalin Marinas, Will Deacon, iivanov, svarbanov, mbrugger,
Jonathan Bell, Phil Elwell, Ulf Hansson,
Broadcom internal kernel review list, Al Cooper, linux-mmc,
Jiri Slaby, linux-serial
Cc: Andrea della Porta
From: "Ivan T. Ivanov" <iivanov@suse.de>
On RPi5 device Bluetooth chips is connected to UARTA
port. Add Bluetooth chips and related pin definitions.
With this and firmware already provided by distributions,
at least on openSUSE Tumbleweed, this is sufficient to make
Bluetooth operational on RPi5 \o/.
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
.../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 42 +++++++++++++++++++
arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 18 ++++++++
2 files changed, 60 insertions(+)
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
index 411b58c1dddf..04738bf281eb 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts
@@ -81,6 +81,11 @@ wl_on_reg: wl-on-reg {
};
&pinctrl {
+ bt_shutdown_default: bt-shutdown-default-state {
+ function = "gpio";
+ pins = "gpio29";
+ };
+
emmc_sd_default: emmc-sd-default-state {
pins = "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat3";
bias-pull-up;
@@ -110,6 +115,29 @@ dat-pins {
};
};
+ uarta_24_default: uarta-24-default-state {
+ rts-pins {
+ function = "uart0";
+ pins = "gpio24";
+ bias-disable;
+ };
+ cts-pins {
+ function = "uart0";
+ pins = "gpio25";
+ bias-pull-up;
+ };
+ txd-pins {
+ function = "uart0";
+ pins = "gpio26";
+ bias-disable;
+ };
+ rxd-pins {
+ function = "uart0";
+ pins = "gpio27";
+ bias-pull-up;
+ };
+ };
+
wl_on_default: wl-on-default-state {
function = "gpio";
pins = "gpio28";
@@ -188,6 +216,20 @@ power: power {
};
};
+/* uarta communicates with the BT module */
+&uarta {
+ uart-has-rtscts;
+ pinctrl-0 = <&uarta_24_default &bt_shutdown_default>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ bluetooth: bluetooth {
+ compatible = "brcm,bcm43438-bt";
+ max-speed = <3000000>;
+ shutdown-gpios = <&gio 29 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&hvs {
clocks = <&firmware_clocks 4>, <&firmware_clocks 16>;
clock-names = "core", "disp";
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
index 871537366e96..8ff254c35b0c 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
+++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
@@ -38,6 +38,13 @@ clk_emmc2: clk-emmc2 {
clock-frequency = <200000000>;
clock-output-names = "emmc2-clock";
};
+
+ clk_sw_baud: clk-sw-baud {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <96000000>;
+ clock-output-names = "sw-baud";
+ };
};
cpus: cpus {
@@ -260,6 +267,17 @@ gio: gpio@7d508500 {
brcm,gpio-bank-widths = <32 22>;
};
+ uarta: serial@7d50c000 {
+ compatible = "brcm,bcm7271-uart";
+ reg = <0x7d50c000 0x20>;
+ reg-names = "uart";
+ clocks = <&clk_sw_baud>;
+ clock-names = "sw_baud";
+ interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "uart";
+ status = "disabled";
+ };
+
pinctrl_aon: pinctrl@7d510700 {
compatible = "brcm,bcm2712c0-aon-pinctrl";
reg = <0x7d510700 0x20>;
--
2.35.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
` (4 preceding siblings ...)
2025-08-28 13:17 ` [PATCH v2 5/5] arm64: dts: broadcom: bcm2712: Add UARTA " Andrea della Porta
@ 2025-08-28 20:31 ` Rob Herring (Arm)
2025-08-29 9:17 ` Andrea della Porta
5 siblings, 1 reply; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-08-28 20:31 UTC (permalink / raw)
To: Andrea della Porta
Cc: linux-arm-kernel, florian.fainelli, Ulf Hansson, linux-gpio,
Jonathan Bell, svarbanov, linus.walleij, devicetree, linux-serial,
Catalin Marinas, conor+dt, Broadcom internal kernel review list,
Jiri Slaby, krzk+dt, Al Cooper, linux-mmc, wahrenst, iivanov,
mbrugger, Will Deacon, Phil Elwell
On Thu, 28 Aug 2025 15:17:09 +0200, Andrea della Porta wrote:
> Hi,
>
> The following patches add a few peripheral DT nodes and related pin/gpio
> nodes for Raspberry Pi 5.
>
> - Patch 1: Amend the bindings to avoid DT compiler warnings.
>
> - Patch 2: Adds core pinctrl nodes and defines SD pins as a first appliance
> for the pinctrl.
>
> - Patch 3: Wires the gpio-key for power button and related gpio controller.
>
> - Patch 4: Adds DT node for WiFi.
>
> - Patch 5: Adds Bluetooth DT node.
>
> All comments and suggestions are welcome!
>
> Happy hacking!
> Ivan and Andrea
>
>
> CHANGES in V2:
>
> --- DTS ---
>
> - bcm2712.dtsi: added a proper clocks node to the uarta serial
> in order to replace the legacy clock-frequency property. As
> a result, the following patch from the previous patchset
> has been dropped since it's now useless:
>
> "dt-bindings: serial: Add clock-frequency property as an alternative to clocks"
>
>
> Andrea della Porta (1):
> dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI
> controller
>
> Ivan T. Ivanov (4):
> arm64: dts: broadcom: bcm2712: Add pin controller nodes
> arm64: dts: broadcom: bcm2712: Add one more GPIO node
> arm64: dts: broadcom: bcm2712: Add second SDHCI controller node
> arm64: dts: broadcom: bcm2712: Add UARTA controller node
>
> .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +-
> .../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 133 ++++++++++++++++++
> arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 55 ++++++++
> 3 files changed, 189 insertions(+), 1 deletion(-)
>
> --
> 2.35.3
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250828 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/broadcom/' for cover.1756386531.git.andrea.porta@suse.com:
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT
2025-08-28 20:31 ` [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Rob Herring (Arm)
@ 2025-08-29 9:17 ` Andrea della Porta
0 siblings, 0 replies; 9+ messages in thread
From: Andrea della Porta @ 2025-08-29 9:17 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Andrea della Porta, linux-arm-kernel, florian.fainelli,
Ulf Hansson, linux-gpio, Jonathan Bell, svarbanov, linus.walleij,
devicetree, linux-serial, Catalin Marinas, conor+dt,
Broadcom internal kernel review list, Jiri Slaby, krzk+dt,
Al Cooper, linux-mmc, wahrenst, iivanov, mbrugger, Will Deacon,
Phil Elwell
Hi Rob,
On 15:31 Thu 28 Aug , Rob Herring (Arm) wrote:
>
> On Thu, 28 Aug 2025 15:17:09 +0200, Andrea della Porta wrote:
> > Hi,
> >
> > The following patches add a few peripheral DT nodes and related pin/gpio
> > nodes for Raspberry Pi 5.
> >
> > - Patch 1: Amend the bindings to avoid DT compiler warnings.
> >
> > - Patch 2: Adds core pinctrl nodes and defines SD pins as a first appliance
> > for the pinctrl.
> >
> > - Patch 3: Wires the gpio-key for power button and related gpio controller.
> >
> > - Patch 4: Adds DT node for WiFi.
> >
> > - Patch 5: Adds Bluetooth DT node.
> >
> > All comments and suggestions are welcome!
> >
> > Happy hacking!
> > Ivan and Andrea
> >
> >
> > CHANGES in V2:
> >
> > --- DTS ---
> >
> > - bcm2712.dtsi: added a proper clocks node to the uarta serial
> > in order to replace the legacy clock-frequency property. As
> > a result, the following patch from the previous patchset
> > has been dropped since it's now useless:
> >
> > "dt-bindings: serial: Add clock-frequency property as an alternative to clocks"
> >
> >
> > Andrea della Porta (1):
> > dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI
> > controller
> >
> > Ivan T. Ivanov (4):
> > arm64: dts: broadcom: bcm2712: Add pin controller nodes
> > arm64: dts: broadcom: bcm2712: Add one more GPIO node
> > arm64: dts: broadcom: bcm2712: Add second SDHCI controller node
> > arm64: dts: broadcom: bcm2712: Add UARTA controller node
> >
> > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +-
> > .../dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dts | 133 ++++++++++++++++++
> > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 55 ++++++++
> > 3 files changed, 189 insertions(+), 1 deletion(-)
> >
> > --
> > 2.35.3
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: attempting to guess base-commit...
> Base: tags/next-20250828 (exact match)
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/broadcom/' for cover.1756386531.git.andrea.porta@suse.com:
>
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-ovl-rp1.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
> arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d504100: failed to match any schema with compatible: ['brcm,bcm2712c0-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: /soc@107c000000/pinctrl@7d510700: failed to match any schema with compatible: ['brcm,bcm2712c0-aon-pinctrl']
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dtb: hvs@107c580000 (brcm,bcm2712-hvs): clocks: [[28, 4], [28, 16]] is too long
> from schema $id: http://devicetree.org/schemas/display/brcm,bcm2835-hvs.yaml#
>
>
For some reason I've dropped, from the previous cover letter, the
phrase mentioning that this patchset depends on this patchset:
https://lore.kernel.org/all/7ed0f2779829f4e63b69d8cf5cedda9f849996bc.1756372805.git.andrea.porta@suse.com/
which contains the schema. If you apply it as prerequisite, warnings
should disappear.
Many thanks,
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
@ 2025-08-29 18:01 ` Rob Herring (Arm)
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2025-08-29 18:01 UTC (permalink / raw)
To: Andrea della Porta
Cc: Al Cooper, svarbanov, florian.fainelli, Jonathan Bell,
Will Deacon, linus.walleij, linux-mmc, linux-arm-kernel,
Ulf Hansson, mbrugger, Catalin Marinas, devicetree, krzk+dt,
wahrenst, conor+dt, linux-serial, Phil Elwell, iivanov,
Jiri Slaby, Broadcom internal kernel review list, linux-gpio
On Thu, 28 Aug 2025 15:17:10 +0200, Andrea della Porta wrote:
> The Broadcom BRCMSTB SDHCI Controller device supports Common
> properties in terms of Capabilities.
>
> Reference sdhci-common schema instead of mmc-controller in order
> for capabilities to be specified in DT nodes avoiding warnings
> from the DT compiler.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-08-29 18:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 13:17 [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 1/5] dt-bindings: mmc: Add support for capabilities to Broadcom SDHCI controller Andrea della Porta
2025-08-29 18:01 ` Rob Herring (Arm)
2025-08-28 13:17 ` [PATCH v2 2/5] arm64: dts: broadcom: bcm2712: Add pin controller nodes Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 3/5] arm64: dts: broadcom: bcm2712: Add one more GPIO node Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 4/5] arm64: dts: broadcom: bcm2712: Add second SDHCI controller node Andrea della Porta
2025-08-28 13:17 ` [PATCH v2 5/5] arm64: dts: broadcom: bcm2712: Add UARTA " Andrea della Porta
2025-08-28 20:31 ` [PATCH v2 0/5] Add peripheral nodes to RaspberryPi 5 DT Rob Herring (Arm)
2025-08-29 9:17 ` Andrea della Porta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).