Re: [PATCH 06/26] brd: convert to blk_alloc_disk/blk_cleanup_disk

Christoph Hellwig
2021-05-24T07:25:01Z

On Sun, May 23, 2021 at 09:58:48AM +0200, Hannes Reinecke wrote:
>> + /*
>> + * This is so fdisk will align partitions on 4k, because of
>> + * direct_access API needing 4k alignment, returning a PFN
>> + * (This is only a problem on very small devices <= 4M,
>> + * otherwise fdisk will align on 1M. Regardless this call
>> + * is harmless)
>> + */
>> + blk_queue_physical_block_size(disk->queue, PAGE_SIZE);
>>
>
> Maybe converting the comment to refer to 'PAGE_SIZE' instead of 4k while
> you're at it ...

I really do not want to touch these kinds of unrelated things here.