Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	robh@kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH v2 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml
Date: Tue, 4 Jun 2024 18:00:51 +0200	[thread overview]
Message-ID: <1a6feb0b-76e3-42a0-8ba7-03d92e2c62f6@kernel.org> (raw)
In-Reply-To: <20240604145308.2417017-1-Frank.Li@nxp.com>

On 04/06/2024 16:53, Frank Li wrote:
> Convert layerscape fsl-esdhc binding doc from txt to yaml format.
> 
> Addtional change during convert:
> - Deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
> - Add "reg" and "interrupts" property.
> - Change example "sdhci@2e000" to "mmc@2e000".
> - Compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
> most existed dts file.
> - Set clock-frequency t

...

> +
> +  sdhci,auto-cmd12:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      specifies that a controller can only handle auto CMD12.
> +
> +  voltage-ranges:
> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +    items:
> +      items:
> +        - description: specifies minimum slot voltage (mV).
> +        - description: specifies maximum slot voltage (mV).

I missed it last time:

This needs min/maxItems, because you constrained only one dimension. I
assume this can be quite flexible, so could be min=1 and maxItems=8, or
whatever slots number is there.

Best regards,
Krzysztof


      reply	other threads:[~2024-06-04 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 14:53 [PATCH v2 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml Frank Li
2024-06-04 16:00 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a6feb0b-76e3-42a0-8ba7-03d92e2c62f6@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox