From: Neil Armstrong <neil.armstrong@linaro.org>
To: Danila Tikhonov <danila@jiaxyga.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-remoteproc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-hardening@vger.kernel.org,
linux@mainlining.org, ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 32/33] dt-bindings: display: panel: samsung,ams581vf01: Add google,sunfish
Date: Wed, 23 Apr 2025 15:43:08 +0200 [thread overview]
Message-ID: <1acbe9dc-02ca-4233-a79a-901e714f5c9c@linaro.org> (raw)
In-Reply-To: <20250422213137.80366-16-danila@jiaxyga.com>
On 22/04/2025 23:31, Danila Tikhonov wrote:
> This panel is used in Google Pixel 4a (google,sunfish). Document the
> corresponding string.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> .../bindings/display/panel/samsung,ams581vf01.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ams581vf01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ams581vf01.yaml
> index 70dff9c0ef2b..a3a1de32d8be 100644
> --- a/Documentation/devicetree/bindings/display/panel/samsung,ams581vf01.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,ams581vf01.yaml
> @@ -17,7 +17,13 @@ allOf:
>
> properties:
> compatible:
> - const: samsung,ams581vf01
> + oneOf:
> + - enum:
> + - samsung,ams581vf01
> + - items:
> + - enum:
> + - google,ams581vf01-sunfish
> + - const: samsung,ams581vf01
Why do you introduce a new compatible ? using samsung,ams581vf01 is prefectly fine
if it's same panel.
Neil
>
> reg:
> maxItems: 1
next prev parent reply other threads:[~2025-04-23 13:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 21:31 [PATCH 17/33] dt-bindings: nvmem: qfprom: Add the SM7150 compatible Danila Tikhonov
2025-04-22 21:31 ` [PATCH 18/33] dt-bindings: crypto: qcom,inline-crypto-engine: " Danila Tikhonov
2025-04-22 21:31 ` [PATCH 19/33] dt-bindings: interconnect: qcom-bwmon: " Danila Tikhonov
2025-04-22 21:31 ` [PATCH 20/33] dt-bindings: i2c: qcom-cci: " Danila Tikhonov
2025-05-12 16:54 ` Krzysztof Kozlowski
2025-05-12 23:35 ` Andi Shyti
2025-04-22 21:31 ` [PATCH 21/33] dt-bindings: clock: qcom-rpmhcc: " Danila Tikhonov
2025-05-12 16:54 ` Krzysztof Kozlowski
2025-04-22 21:31 ` [PATCH 22/33] dt-bindings: interconnect: OSM L3: " Danila Tikhonov
2025-04-22 21:31 ` [PATCH 23/33] dt-bindings: arm-smmu: " Danila Tikhonov
2025-05-12 16:54 ` Krzysztof Kozlowski
2025-04-22 21:31 ` [PATCH 24/33] dt-bindings: clock: qcom,gpucc: " Danila Tikhonov
2025-05-12 16:54 ` Krzysztof Kozlowski
2025-04-22 21:31 ` [PATCH 25/33] dt-bindings: remoteproc: qcom: sc7180-pas: " Danila Tikhonov
2025-05-12 16:55 ` Krzysztof Kozlowski
2025-04-22 21:31 ` [PATCH 26/33] remoteproc: qcom: pas: Add SM7150 remoteproc support Danila Tikhonov
2025-05-12 16:55 ` Krzysztof Kozlowski
2025-04-22 21:31 ` [PATCH 27/33] soc: qcom: pd-mapper: Add support for SM7150 Danila Tikhonov
2025-04-23 13:30 ` Dmitry Baryshkov
2025-04-22 21:31 ` [PATCH 28/33] cpufreq: Add SM7150 to cpufreq-dt-platdev blocklist Danila Tikhonov
2025-04-23 13:30 ` Dmitry Baryshkov
2025-04-22 21:31 ` [PATCH 29/33] firmware: qcom: tzmem: disable sm7150 platform Danila Tikhonov
2025-04-23 13:31 ` Dmitry Baryshkov
2025-04-22 21:31 ` [PATCH 30/33] arm64: dts: qcom: Add dtsi for Snapdragon 730/730g/732g (SM7150) SoCs Danila Tikhonov
2025-04-23 12:18 ` Konrad Dybcio
2025-04-22 21:31 ` [PATCH 31/33] dt-bindings: arm: qcom: Add SM7150 Google Pixel 4a Danila Tikhonov
2025-04-22 21:31 ` [PATCH 32/33] dt-bindings: display: panel: samsung,ams581vf01: Add google,sunfish Danila Tikhonov
2025-04-23 13:43 ` Neil Armstrong [this message]
2025-05-09 22:13 ` (subset) [PATCH 17/33] dt-bindings: nvmem: qfprom: Add the SM7150 compatible Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1acbe9dc-02ca-4233-a79a-901e714f5c9c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox