From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-f-sdh30: Replace with sdhci_pltfm
Date: Fri, 30 Jun 2023 09:34:51 +0900 [thread overview]
Message-ID: <1c2a9e31-4ecc-17cb-3be7-8607dbc29329@socionext.com> (raw)
In-Reply-To: <57dd6bdc-c8dc-219c-f9dd-d2f210a5ce2c@intel.com>
Hi Adrian,
On 2023/06/29 21:57, Adrian Hunter wrote:
> On 29/06/23 03:49, Kunihiko Hayashi wrote:
>> Even if sdhci_pltfm_pmops is specified for PM, this driver doesn't apply
>> sdhci_pltfm, so the structure is not correctly referenced in PM functions.
>> This applies sdhci_pltfm to this driver to fix this issue.
>>
>> - Call sdhci_pltfm_init() instead of sdhci_alloc_host() and
>> other functions that covered by sdhci_pltfm.
>> - Move ops and quirks to sdhci_pltfm_data
>> - Replace sdhci_priv() with own private function sdhci_f_sdh30_priv().
>>
>
> Does it need a Fixes tag?
Ah, I see. I'll add it in v2.
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>
> Otherwise:
>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2023-06-30 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 0:49 [PATCH] mmc: sdhci-f-sdh30: Replace with sdhci_pltfm Kunihiko Hayashi
2023-06-29 12:57 ` Adrian Hunter
2023-06-30 0:34 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c2a9e31-4ecc-17cb-3be7-8607dbc29329@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox