From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Angelo Dureghello <adureghello@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Ben Dooks <ben-linux@fluff.org>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] mmc: sdhci-sprd: Constify struct sdhci_ops
Date: Mon, 15 Apr 2024 09:45:37 +0800 [thread overview]
Message-ID: <1cc8e549-11a7-463a-ad74-527ccacb744a@linux.alibaba.com> (raw)
In-Reply-To: <20240414-mmc-const-sdhci-ops-v2-3-262f81faadac@kernel.org>
On 2024/4/14 22:07, Krzysztof Kozlowski wrote:
> The local struct sdhci_ops can be made const for code safety.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 685b1c648901..8776f4287119 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -439,7 +439,7 @@ static void sdhci_sprd_set_power(struct sdhci_host *host, unsigned char mode,
> }
> }
>
> -static struct sdhci_ops sdhci_sprd_ops = {
> +static const struct sdhci_ops sdhci_sprd_ops = {
> .read_l = sdhci_sprd_readl,
> .write_l = sdhci_sprd_writel,
> .write_w = sdhci_sprd_writew,
>
next prev parent reply other threads:[~2024-04-15 1:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 14:07 [PATCH v2 0/5] mmc: Constify struct sdhci_ops Krzysztof Kozlowski
2024-04-14 14:07 ` [PATCH v2 1/5] mmc: sdhci-esdhc-mcf: " Krzysztof Kozlowski
2024-04-14 14:07 ` [PATCH v2 2/5] mmc: sdhci-omap: " Krzysztof Kozlowski
2024-04-14 14:07 ` [PATCH v2 3/5] mmc: sdhci-sprd: " Krzysztof Kozlowski
2024-04-15 1:45 ` Baolin Wang [this message]
2024-04-14 14:07 ` [PATCH v2 4/5] mmc: sdhci_am654: " Krzysztof Kozlowski
2024-04-14 14:07 ` [PATCH v2 5/5] mmc: sdhci-s3c: Choose sdhci_ops based on variant Krzysztof Kozlowski
2024-04-15 6:07 ` [PATCH v2 0/5] mmc: Constify struct sdhci_ops Adrian Hunter
2024-04-25 16:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cc8e549-11a7-463a-ad74-527ccacb744a@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=adrian.hunter@intel.com \
--cc=adureghello@baylibre.com \
--cc=ben-linux@fluff.org \
--cc=jh80.chung@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox