From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF7BC25B6B for ; Thu, 26 Oct 2023 09:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjJZJFU (ORCPT ); Thu, 26 Oct 2023 05:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbjJZJFS (ORCPT ); Thu, 26 Oct 2023 05:05:18 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD4A210E for ; Thu, 26 Oct 2023 02:05:15 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507c5249d55so920229e87.3 for ; Thu, 26 Oct 2023 02:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1698311114; x=1698915914; darn=vger.kernel.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=2oJ1jlhG9oorUzXX4oCyrJv+zqn7eGeLFSxbQPDqXZA=; b=ESKih3a57luFdaSENN83jzufTDZnZFreqhyMIaY3HwW3yOCS8bGmDeM8yW1IDWrwMe HQCT+V2CKMdIy1K3qsAURH0m8iTAFzbqQ/vWInQ9DtRb0faDxRkus9eu/bVnbHaGzHip bDuYbkLLX+k+398lKiK3Zr3z/E9ULiL8+CwkbLAPzQvtmrhoZuVOQsVES1K7k1iKsCOv 6R5rAAfe4uVcD6sVoZP67vFAD6Ocl0lJnINVdfCdCTLoBja5iLFiq9z88iHfXnZtjugw +iEUKQrui/+ozLxAejZnxPX4wfV33gYS0Dc9khZmiVScuHVFlHI9iC4I5z7MEnZN/ykF cL9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698311114; x=1698915914; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2oJ1jlhG9oorUzXX4oCyrJv+zqn7eGeLFSxbQPDqXZA=; b=WP00DK5bbGIi3ITbjab0+i3ZPWh1M7cOATJ/KbL8i1OJUy+bFPVCD3s6Do+HI7QZn3 wVd/dLbGaDm38eFUeitpm8QJL1iVCk61JAXaM8JL00wy7Wfh1/U3rPvrCSIJ6h3e99/b pu5XLnVXMK1IhirGwyVTTt+pt6lgTBIKZCC2S3Q4iCbpwEMqoxYfMkH4bU34m2nviQ2R R4aqDb6XKa/F1JKOJchLE4jX/rBxgRigbrGY2hbxTxCkGNl0csvryrsgWr21Wb12wOaX Zl58Z1TLcOgxGLU9wdYOgWnJCFGw+F/PdPpgI+V954f3gQDn1WNjAE75Yh4hTv6Y0u8m zclQ== X-Gm-Message-State: AOJu0YxiuBcBJe0+keapurJ4vlXNcnNTtt5Cm9XGQAslcScr6hhF274G g6LKMCylZib3ZepDwa5gZVwH4w== X-Google-Smtp-Source: AGHT+IEcCo3MOL+v7ls4UAXtPy1Nexq4e+KJmgrR62ctOhHdOSO3Z3oUqSIP3cFHn7yVMZtyqgo36Q== X-Received: by 2002:ac2:538b:0:b0:507:ae8b:a573 with SMTP id g11-20020ac2538b000000b00507ae8ba573mr12792622lfh.51.1698311113795; Thu, 26 Oct 2023 02:05:13 -0700 (PDT) Received: from localhost ([2a01:e0a:3c5:5fb1:d5c0:32f3:899b:123c]) by smtp.gmail.com with ESMTPSA id az32-20020a05600c602000b004053e9276easm2005317wmb.32.2023.10.26.02.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 02:05:13 -0700 (PDT) References: <20231026073156.2868310-1-rong.chen@amlogic.com> User-agent: mu4e 1.8.13; emacs 29.1 From: Jerome Brunet To: "Rong.Chen" , Ulf Hansson , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mmc: meson-gx: Remove setting of CMD_CFG_ERROR Date: Thu, 26 Oct 2023 11:01:53 +0200 In-reply-to: <20231026073156.2868310-1-rong.chen@amlogic.com> Message-ID: <1j34xx4uuv.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu 26 Oct 2023 at 15:31, "Rong.Chen" wrote: > From: Rong Chen > > For the t7 and older SoC families, the CMD_CFG_ERROR has no effect. > Starting from SoC family C3, setting this bit without SG LINK data > address will cause the controller to generate an IRQ and stop working. > > To fix it, don't set the bit CMD_CFG_ERROR anymore. > > Fixes: 18f92bc02f17 ("mmc: meson-gx: make sure the descriptor is stopped on errors") > Signed-off-by: Rong Chen > --- > drivers/mmc/host/meson-gx-mmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 9837dab096e6..c7c067b9415a 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd) > > cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode); > cmd_cfg |= CMD_CFG_OWNER; /* owned by CPU */ > - cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */ > > meson_mmc_set_response_bits(cmd, &cmd_cfg); Reviewed-by: Jerome Brunet