From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Regression in suspend to ram in 2.6.31-rc kernels Date: Fri, 11 Sep 2009 23:51:17 +0200 Message-ID: <20090911215117.GA11441@elf.ucw.cz> References: <87iqfx5mss.fsf@devron.myhome.or.jp> <20090907125130.GA1595@ucw.cz> <87ljko5k3v.fsf@devron.myhome.or.jp> <20090910192354.GD23356@elf.ucw.cz> <87bplim1ce.fsf@devron.myhome.or.jp> <20090911200922.GF8137@elf.ucw.cz> <20090911213204.GC25544@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49481 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755992AbZIKVvW (ORCPT ); Fri, 11 Sep 2009 17:51:22 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Zdenek Kabelac Cc: OGAWA Hirofumi , Christoph Hellwig , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-mmc@vger.kernel.org, viro@zeniv.linux.org.uk On Fri 2009-09-11 23:45:01, Zdenek Kabelac wrote: > 2009/9/11 Pavel Machek : > > > >> And why suspend of mmc should generate card removal ?? > > > > Card is powered down during suspend -> mmc can't guarantee the card is > > same and unchanged -> it makes some sense to simulate > > removal/reinsert. > > But how is this going to work when I keep the device mounted and > blockdev is basically destroyed - what if I'm reading file from card > during suspend ? "Don't do it". > >> if I suspend and resume my laptop and I keep the card inside - all > >> those step looks plain wrong. > > > > Unfortunately system can't tell. > > Well system could check basic card ids if they match after resume - if > some users wants to crash his card by randomly swapping it during > suspend/resume - I'd have no problem with that.... Well, I do have small problem with that :-). Anyway, patch for rechecking IDs would probably be accepted, but that's not how it works now. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html