Re: Regression in suspend to ram in 2.6.31-rc kernels

OGAWA Hirofumi
2009-09-09T13:21:55Z

Pavel Machek <pavel@ucw.cz> writes:

>> It seems
>>
>> 1) sync() (probabry "sync" command)
>> 2) sync as part of suspend sequence
>> 3) sync_filesystem() by mmc remove event
>>
>> I guess the root-cause of the problem would be 3). However, it would not
>> be easy to fix, at least, we would need to think about what we want to
>> do for it. So, to workaround it for now, I've made this patch.
>
> MMC driver trying to synchronize filesystems looks like ugly layering
> violation to me. Why are we doing that?

There is no _layering violation_ here. IIRC, mmc just tells card removed
event to another layer (on some points of view, to tell event can be
wrong though). The partition (block) layer does it by event.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>