From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Regression in suspend to ram in 2.6.31-rc kernels Date: Mon, 14 Sep 2009 22:25:59 +0200 Message-ID: <20090914202558.GA10398@elf.ucw.cz> References: <20090907125130.GA1595@ucw.cz> <87ljko5k3v.fsf@devron.myhome.or.jp> <20090910192354.GD23356@elf.ucw.cz> <87bplim1ce.fsf@devron.myhome.or.jp> <20090911200922.GF8137@elf.ucw.cz> <20090911213204.GC25544@elf.ucw.cz> <20090911215117.GA11441@elf.ucw.cz> <20090914220510.5558d215@mjolnir.ossman.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33987 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932733AbZINU0D (ORCPT ); Mon, 14 Sep 2009 16:26:03 -0400 Content-Disposition: inline In-Reply-To: <20090914220510.5558d215@mjolnir.ossman.eu> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Pierre Ossman Cc: Zdenek Kabelac , OGAWA Hirofumi , Christoph Hellwig , "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-mmc@vger.kernel.org, viro@zeniv.linux.org.uk On Mon 2009-09-14 22:05:10, Pierre Ossman wrote: > On Fri, 11 Sep 2009 23:51:17 +0200 > Pavel Machek wrote: > > > On Fri 2009-09-11 23:45:01, Zdenek Kabelac wrote: > > > > > > Well system could check basic card ids if they match after resume - if > > > some users wants to crash his card by randomly swapping it during > > > suspend/resume - I'd have no problem with that.... > > > > Well, I do have small problem with that :-). > > > > Anyway, patch for rechecking IDs would probably be accepted, but > > that's not how it works now. > > It _does_ check the card id when you have UNSAFE_RESUME selected. It > doesn't just hook up whatever card you happen to have in the slot with > your old block device. I may have a lot of opponents when it comes > to my suspend design choices, but I'm not completely crazy. ;) :-) Ok, ok. Patch checking filesystem timestamps would be welcome in that case ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html