Re: [PATCH] sdhci: Increase timeout for internal clock stabilization.

[Pierre Ossman <pierre@ossman.eu>]

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Fri, 18 Sep 2009 18:15:56 -0400
Chris Ball <cjb@laptop.org> wrote:

> On an OLPC XO-1.5 development board with Via VX855 chipset, the sdhci
> controller can take up to 12ms to stabilize its clock, but the current
> timeout at which we give up on the controller is 10ms.
> 
> The patch increases the timeout delay rather than using a device-specific
> quirk -- since we exit the loop when the clock comes up, increasing the
> timeout value will only make us mdelay() longer in the errant case of a
> device with a clock that is not stabilizing, which it seems worth waiting
> a little longer for in general.
> 
> Signed-off-by: Chris Ball <cjb@laptop.org>
> Cc: Harald Welte <HaraldWelte@viatech.com>
> ---

Seems reasonable enough to me. The initial limit was completely
arbitrary anyway.

Acked-by: Pierre Ossman <pierre@ossman.eu>

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]