public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: avorontsov@ru.mvista.com
Cc: Anton Vorontsov <cbouatmailru@gmail.com>,
	torvalds@linux-foundation.org, ben@fluff.org,
	benh@kernel.crashing.org, david.vrabel@csr.com,
	galak@kernel.crashing.org, linux-mmc@vger.kernel.org,
	pierre@ossman.eu, s.hauer@pengutronix.de
Subject: Re: [patch 084/232] powerpc/85xx: add eSDHC support for MPC8536DS boards
Date: Tue, 22 Sep 2009 17:56:57 -0700	[thread overview]
Message-ID: <20090922175657.ae347784.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090923003200.GA21228@oksana.dev.rtsoft.ru>

On Wed, 23 Sep 2009 04:32:00 +0400 Anton Vorontsov <cbouatmailru@gmail.com> wrote:

> On Tue, Sep 22, 2009 at 04:45:17PM -0700, akpm@linux-foundation.org wrote:
> > From: Anton Vorontsov <avorontsov@ru.mvista.com>
> > 
> > This patch simply adds sdhci node to the device tree.
> > 
> > We specify clock-frequency manually, so that eSDHC will work without
> > upgrading U-Boot.  Though, that'll only work for default setup (1500 MHz)
> > on new board revisions.  For non-default setups, it's recommended to
> > upgrade U-Boot, since it will fixup clock-frequency automatically.
> > 
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > Cc: Pierre Ossman <pierre@ossman.eu>
> > Cc: Kumar Gala <galak@kernel.crashing.org>
> > Cc: David Vrabel <david.vrabel@csr.com>
> > Cc: Ben Dooks <ben@fluff.org>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: <linux-mmc@vger.kernel.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > 
> >  arch/powerpc/boot/dts/mpc8536ds.dts |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff -puN arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards arch/powerpc/boot/dts/mpc8536ds.dts
> > --- a/arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards
> > +++ a/arch/powerpc/boot/dts/mpc8536ds.dts
> > @@ -258,6 +258,14 @@
> >  			clock-frequency = <250000000>;
> >  		};
> 
> By "clock-frequency = <250000000>;" above and the one down below*
> I can see that this patch is already applied (via powerpc tree).
> 
> Please don't merge this particular patch, it's already there.
> 
> > +		sdhci@2e000 {
> > +			compatible = "fsl,mpc8536-esdhc", "fsl,esdhc";
> > +			reg = <0x2e000 0x1000>;
> > +			interrupts = <72 0x2>;
> > +			interrupt-parent = <&mpic>;
> > +			clock-frequency = <250000000>;
> 
> *
> 
> > +		};
> > +
> >  		serial0: serial@4500 {
> >  			cell-index = <0>;
> >  			device_type = "serial";
> > _

So someone went and stole [patch 7/7] from your series and didn't tell me?

I wasn't expecting that.

  reply	other threads:[~2009-09-23  0:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 23:45 [patch 084/232] powerpc/85xx: add eSDHC support for MPC8536DS boards akpm
2009-09-23  0:32 ` Anton Vorontsov
2009-09-23  0:56   ` Andrew Morton [this message]
2009-09-23  1:16     ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090922175657.ae347784.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=ben@fluff.org \
    --cc=benh@kernel.crashing.org \
    --cc=cbouatmailru@gmail.com \
    --cc=david.vrabel@csr.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=s.hauer@pengutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox