Re: [patch 084/232] powerpc/85xx: add eSDHC support for MPC8536DS boards

[Anton Vorontsov <cbouatmailru@gmail.com>]

On Tue, Sep 22, 2009 at 04:45:17PM -0700, akpm@linux-foundation.org wrote:
> From: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> This patch simply adds sdhci node to the device tree.
> 
> We specify clock-frequency manually, so that eSDHC will work without
> upgrading U-Boot.  Though, that'll only work for default setup (1500 MHz)
> on new board revisions.  For non-default setups, it's recommended to
> upgrade U-Boot, since it will fixup clock-frequency automatically.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> Cc: Pierre Ossman <pierre@ossman.eu>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Cc: David Vrabel <david.vrabel@csr.com>
> Cc: Ben Dooks <ben@fluff.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: <linux-mmc@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/powerpc/boot/dts/mpc8536ds.dts |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff -puN arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards arch/powerpc/boot/dts/mpc8536ds.dts
> --- a/arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards
> +++ a/arch/powerpc/boot/dts/mpc8536ds.dts
> @@ -258,6 +258,14 @@
>  			clock-frequency = <250000000>;
>  		};

By "clock-frequency = <250000000>;" above and the one down below*
I can see that this patch is already applied (via powerpc tree).

Please don't merge this particular patch, it's already there.

> +		sdhci@2e000 {
> +			compatible = "fsl,mpc8536-esdhc", "fsl,esdhc";
> +			reg = <0x2e000 0x1000>;
> +			interrupts = <72 0x2>;
> +			interrupt-parent = <&mpic>;
> +			clock-frequency = <250000000>;

*

> +		};
> +
>  		serial0: serial@4500 {
>  			cell-index = <0>;
>  			device_type = "serial";
> _

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2