From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [patch 084/232] powerpc/85xx: add eSDHC support for MPC8536DS boards Date: Wed, 23 Sep 2009 05:16:50 +0400 Message-ID: <20090923011650.GA26325@oksana.dev.rtsoft.ru> References: <200909222345.n8MNjHtJ013999@imap1.linux-foundation.org> <20090923003200.GA21228@oksana.dev.rtsoft.ru> <20090922175657.ae347784.akpm@linux-foundation.org> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-ew0-f211.google.com ([209.85.219.211]:58007 "EHLO mail-ew0-f211.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbZIWBYb (ORCPT ); Tue, 22 Sep 2009 21:24:31 -0400 Received: by ewy7 with SMTP id 7so283562ewy.17 for ; Tue, 22 Sep 2009 18:24:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20090922175657.ae347784.akpm@linux-foundation.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Andrew Morton Cc: avorontsov@ru.mvista.com, torvalds@linux-foundation.org, ben@fluff.org, benh@kernel.crashing.org, david.vrabel@csr.com, galak@kernel.crashing.org, linux-mmc@vger.kernel.org, pierre@ossman.eu, s.hauer@pengutronix.de On Tue, Sep 22, 2009 at 05:56:57PM -0700, Andrew Morton wrote: > On Wed, 23 Sep 2009 04:32:00 +0400 Anton Vorontsov wrote: > > > On Tue, Sep 22, 2009 at 04:45:17PM -0700, akpm@linux-foundation.org wrote: > > > From: Anton Vorontsov > > > > > > This patch simply adds sdhci node to the device tree. > > > > > > We specify clock-frequency manually, so that eSDHC will work without > > > upgrading U-Boot. Though, that'll only work for default setup (1500 MHz) > > > on new board revisions. For non-default setups, it's recommended to > > > upgrade U-Boot, since it will fixup clock-frequency automatically. > > > > > > Signed-off-by: Anton Vorontsov > > > Cc: Pierre Ossman > > > Cc: Kumar Gala > > > Cc: David Vrabel > > > Cc: Ben Dooks > > > Cc: Sascha Hauer > > > Cc: Benjamin Herrenschmidt > > > Cc: > > > Signed-off-by: Andrew Morton > > > --- > > > > > > arch/powerpc/boot/dts/mpc8536ds.dts | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff -puN arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards arch/powerpc/boot/dts/mpc8536ds.dts > > > --- a/arch/powerpc/boot/dts/mpc8536ds.dts~powerpc-85xx-add-esdhc-support-for-mpc8536ds-boards > > > +++ a/arch/powerpc/boot/dts/mpc8536ds.dts > > > @@ -258,6 +258,14 @@ > > > clock-frequency = <250000000>; > > > }; > > > > By "clock-frequency = <250000000>;" above and the one down below* > > I can see that this patch is already applied (via powerpc tree). > > > > Please don't merge this particular patch, it's already there. > > > > > + sdhci@2e000 { > > > + compatible = "fsl,mpc8536-esdhc", "fsl,esdhc"; > > > + reg = <0x2e000 0x1000>; > > > + interrupts = <72 0x2>; > > > + interrupt-parent = <&mpic>; > > > + clock-frequency = <250000000>; > > > > * > > > > > + }; > > > + > > > serial0: serial@4500 { > > > cell-index = <0>; > > > device_type = "serial"; > > > _ > > So someone went and stole [patch 7/7] from your series and didn't tell me? Kumar told that he applied it to his next tree, you were Cc'ed. http://lkml.org/lkml/2009/8/25/235 Thanks, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2