From: Matt Fleming <matt@console-pimps.org>
To: Mahadev Cholachagudda <mgudda@gmail.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] CMD12 error recovery support for SD cards
Date: Wed, 23 Sep 2009 11:27:15 +0100 [thread overview]
Message-ID: <20090923102715.GA4307@console-pimps.org> (raw)
In-Reply-To: <bd31ea570909160339l5f996e9eh1f87abdbe527a404@mail.gmail.com>
On Wed, Sep 16, 2009 at 04:09:11PM +0530, Mahadev Cholachagudda wrote:
> Dear All,
>
> I've a kernel code base of 2.6.28.9, where in I find that CMD12 error
> recovery is not been implemented. It is a wise idea to implement CMD12
> error recovery, that involves sending CMD13 to get the status of the
> card. If the card is in "trans" state, it means CMD12 error shall be
> treated as successfull. If card state is not in "trans", then we have
> to send CMD12 again to stop the data transfer and then checking of the
> card status through CMD13. This sequence is detailed in the
> "Simplified Host Controller specification" on SDCard website. I
> believe this is the case for any controller, though I may be wrong.
>
> With the modification done to the code which is attached as patch to
> the latest mmc git, it is working at our site. And we do see some
> errors with the SDIO controller (proprietary but meets Standard SD
> host controller specification) that we are using.
>
> Request you to comment on the patch.
>
In principal this patch seems OK. However, I recommend reading
Documentation/CodingStyle and sending this patch again once you've fixed
up the coding style and whitespace errors.
Is there a specific reason that you have used mmc_wait_for_req() instead
of mmc_wait_for_cmd() and reusing the "cmd" local variable? The empty
"else" clauses can also probably be deleted.
next prev parent reply other threads:[~2009-09-23 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bd31ea570909160334u1b17a068hd8be89c7035232f9@mail.gmail.com>
2009-09-16 10:39 ` [PATCH 1/1] CMD12 error recovery support for SD cards Mahadev Cholachagudda
2009-09-23 8:50 ` Mahadev Cholachagudda
2009-09-23 10:27 ` Matt Fleming [this message]
2009-09-30 11:18 ` Mahadev Cholachagudda
2009-10-02 10:20 ` Matt Fleming
2009-10-05 4:23 ` Mahadev Cholachagudda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923102715.GA4307@console-pimps.org \
--to=matt@console-pimps.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mgudda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox