From: Andrew Morton <akpm@linux-foundation.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: ohad@bencohen.org, philipl@overt.org, ian@mnementh.co.uk,
pierre@ossman.eu, roberto.foglietta@gmail.com,
david.vrabel@csr.com, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability
Date: Mon, 28 Sep 2009 15:59:00 -0700 [thread overview]
Message-ID: <20090928155900.36dfda0b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090928181046.GA4791@console-pimps.org>
On Mon, 28 Sep 2009 19:10:48 +0100
Matt Fleming <matt@console-pimps.org> wrote:
> >
> > + if ((ocr & MMC_VDD_165_195) && !(host->caps & MMC_CAP_VDD_165_195)) {
> > + printk(KERN_WARNING "%s: SDIO card claims to support the "
> > + "incompletely defined 'low voltage range'. This "
> > + "will be ignored.\n", mmc_hostname(host));
> > + ocr &= ~MMC_VDD_165_195;
> > + }
> > +
> > host->ocr = mmc_select_voltage(host, ocr);
> >
> > /*
>
>
> I know you copied this warning from the old code
It'd be better to avoid copying anything at all. Are we missing
code-sharing opportunities here?
> but does anyone think
> it's worth making this warning a bit clearer? e.g,
>
> > + printk(KERN_WARNING "%s: SDIO card claims to support the "
> > + "incompletely defined 'low voltage range', but the "
> > + "host controller does not. This voltage range"
> > + "will be ignored.\n", mmc_hostname(host));
That looks better to me.
next prev parent reply other threads:[~2009-09-28 22:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 17:58 [PATCH] sdio: add MMC_CAP_VDD_165_195 host capability Ohad Ben-Cohen
2009-09-28 18:10 ` Matt Fleming
2009-09-28 20:10 ` Ohad Ben-Cohen
2009-09-28 22:59 ` Andrew Morton [this message]
2009-09-29 5:53 ` Matt Fleming
-- strict thread matches above, loose matches on Subject: below --
2009-09-28 17:55 Ohad Ben-Cohen
2009-09-28 17:51 Ohad Ben-Cohen
2009-09-28 18:09 ` David Vrabel
2009-09-28 20:02 ` Ohad Ben-Cohen
2009-09-29 2:25 ` Philip Langdale
2009-09-29 18:28 ` Pierre Ossman
2009-09-29 20:20 ` Philip Langdale
2009-09-29 21:37 ` Pierre Ossman
2009-09-30 6:10 ` Philip Langdale
2009-10-08 18:38 ` Pierre Ossman
2009-10-10 18:42 ` Philip Langdale
2009-10-12 13:11 ` David Vrabel
2009-10-13 2:39 ` Philip Langdale
2009-10-14 7:56 ` Ohad Ben-Cohen
2009-10-14 8:48 ` Pierre Ossman
2009-10-14 10:34 ` David Vrabel
2009-10-14 11:05 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928155900.36dfda0b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david.vrabel@csr.com \
--cc=ian@mnementh.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=ohad@bencohen.org \
--cc=philipl@overt.org \
--cc=pierre@ossman.eu \
--cc=roberto.foglietta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox