From: Pierre Ossman <pierre@ossman.eu>
To: Mahadev Cholachagudda <mgudda@gmail.com>
Cc: linux-mmc@vger.kernel.org, Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH 1/1] Implementation for knowing speed_class of inserted SD card from user space
Date: Wed, 30 Sep 2009 14:17:57 +0200 [thread overview]
Message-ID: <20090930141757.293dd589@mjolnir.ossman.eu> (raw)
In-Reply-To: <bd31ea570909300452u49ec17b3h4399da986dd2f78@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Wed, 30 Sep 2009 17:22:14 +0530
Mahadev Cholachagudda <mgudda@gmail.com> wrote:
>
> Let me know if you have any comments/suggestions?
>
I have a few:
1. The obvious one; why? When does user space need to know the speed
rating, and is the speed rating still meaningful after all the layers
in the kernel? Userspace ABI stuff should be added with great care.
2. I think it's better to not show the attribute when it isn't relevant
rather than return 0xFF.
3. Isn't this a SD 2.0 feature? So you should check the version of the
card before populating/showing this field.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2009-09-30 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 11:52 [PATCH 1/1] Implementation for knowing speed_class of inserted SD card from user space Mahadev Cholachagudda
2009-09-30 12:17 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090930141757.293dd589@mjolnir.ossman.eu \
--to=pierre@ossman.eu \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mgudda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox