70a3341a71 broke omap_hsmmc?

70a3341a71 broke omap_hsmmc?

[Uwe Kleine-König]

Hello,

commit 70a3341a711f27ae77714ae7dd360a4e7e2d5e7c changed registering of
omap_hsmmc_host from using platform_driver_probe to using
platform_driver_register.  But omap_hsmmc_driver doesn't have a probe
entry.  So I expect that the driver doesn't bind correctly.

The fix is either convert back to platform_driver_probe or (add
platform_driver_probe to omap_hsmmc_driver and move it to section
.devinit.text).

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Re: 70a3341a71 broke omap_hsmmc?

[Madhusudhan Chikkature]

Hi,

A fix for this is pushed in Linux-omap.

Regards,
Madhu

commit fa7705edb1355a52cdca0adfcfe007923bfff7dc
Author: Roger Quadros <ext-roger.quadros@nokia.com>
Date:   Mon Oct 5 13:50:06 2009 -0700

    omap_hsmmc: Add missing probe handler hook to platform driver data

    The missing probe handler hook will never probe the driver. Add it back.
    Fixes broken MMC on OMAP.

    We use platform_driver_probe() API since omap_hsmmc is not a hot-pluggable
    device.

    Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4487cc0..0aecaae 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2013,7 +2013,7 @@ static struct platform_driver omap_hsmmc_driver = {
 static int __init omap_hsmmc_init(void)
 {
        /* Register the MMC driver */
-       return platform_driver_register(&omap_hsmmc_driver);
+       return platform_driver_probe(&omap_hsmmc_driver, omap_hsmmc_probe);
 }

 static void __exit omap_hsmmc_cleanup(void)



> Hello,
>
> commit 70a3341a711f27ae77714ae7dd360a4e7e2d5e7c changed registering of
> omap_hsmmc_host from using platform_driver_probe to using
> platform_driver_register.  But omap_hsmmc_driver doesn't have a probe
> entry.  So I expect that the driver doesn't bind correctly.
>
> The fix is either convert back to platform_driver_probe or (add
> platform_driver_probe to omap_hsmmc_driver and move it to section
> .devinit.text).
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K.                              | Uwe Kleine-König            |
> Industrial Linux Solutions                    | http://www.pengutronix.de/  |
>
>