From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-mmc@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: msm_sdcc.c: add missing include
Date: Thu, 22 Oct 2009 19:51:26 +0100 [thread overview]
Message-ID: <20091022185126.GA4401@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20091022072119.GA3285@elf.ucw.cz>
On Thu, Oct 22, 2009 at 09:21:19AM +0200, Pavel Machek wrote:
>
> Add missing include for msm_sdcc compilation.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
I don't think this is the right solution - why should MSM have a
platform specific include in the ARM generic include files?
(If anything, we should be getting rid of any non-shared platform
specific includes in the arch/arm/include/asm/mach directory.)
next prev parent reply other threads:[~2009-10-22 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 7:21 msm_sdcc.c: add missing include Pavel Machek
2009-10-22 18:51 ` Russell King - ARM Linux [this message]
2009-11-02 11:12 ` msm_sdcc.c: add missing include, fix compilation Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022185126.GA4401@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox