public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"504391@bugs.debian.org" <504391@bugs.debian.org>,
	Wouter van Heyst <larstiq@larstiq.dyndns.org>
Subject: Re: [PATCH] mmc: add module parameter to set whether cards are assumed removable
Date: Mon, 30 Nov 2009 12:48:44 +0000	[thread overview]
Message-ID: <20091130124844.6ec0b8da@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4B13BCD1.9040000@nokia.com>

> You do not cater for having more than one slot e.g. N900 has two:
> one internal non-removable and one external that is removable.
> 
> What about a sysfs entry instead e.g.
> 
>  /sys/class/mmc-host/mmc*/nonremovable

That continues the assumption that the user will somehow ever know about
this stuff and configure it. Almost nobody will.

Not only does it need to be per-port there needs to be a credible
description of how it will automatically happen - who configures it,
when, how and is the data needed available.


      reply	other threads:[~2009-11-30 12:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  4:44 [PATCH] mmc: add module parameter to set whether cards are assumed removable Ben Hutchings
2009-11-16 20:23 ` Andrew Morton
2009-11-16 22:31   ` Ben Hutchings
2009-11-17  7:53     ` Stefan Richter
2009-11-30 12:39       ` Pierre Ossman
2009-11-30 12:54         ` Alan Cox
2009-11-30 13:09           ` Pierre Ossman
2009-11-30 13:32         ` Maxim Levitsky
2009-11-30 13:51           ` Alan Cox
2009-11-30 15:27             ` Maxim Levitsky
2009-11-22 11:42     ` Bug#504391: " Wouter van Heyst
2009-11-22 12:32       ` Ben Hutchings
2009-12-01 19:57         ` Wouter van Heyst
2009-11-30 12:38 ` Adrian Hunter
2009-11-30 12:48   ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091130124844.6ec0b8da@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=504391@bugs.debian.org \
    --cc=adrian.hunter@nokia.com \
    --cc=ben@decadent.org.uk \
    --cc=larstiq@larstiq.dyndns.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox