From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Ma <pma@mediamatech.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo
Date: Mon, 28 Dec 2009 11:34:36 +0100 [thread overview]
Message-ID: <200912281134.36763.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20091228112028.5babace2@hskinnemoen-d830>
Am Montag 28 Dezember 2009 11:20:28 schrieb Haavard Skinnemoen:
> Peter Hüwe <PeterHuewe@gmx.de> wrote:
> > Great, thanks for the update.
> > The only thing that still catches my eye is that the kzalloc line can
> > fail, so you should perhaps add something like
> > if (!slave) {
> > printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc");
> > goto fail;
> > }
>
> I agree, except that this is extremely unlikely to happen, so we should
> either drop the printk() or use pr_debug() in order to waste as little
> memory as possible in production systems.
ok.
>
> I think your first patch is good as it is, so I will apply it. Please
> send any additional fixes as a separate patch.
Okay thanks for applying.
@Hans: can you create the cleanup patch or should I ?
Regards,
Peter
next prev parent reply other threads:[~2009-12-28 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 19:08 [PATCH] arch/avr32: Fix build failure for avr32 caused by typo Peter Huewe
2009-12-28 8:13 ` Hans-Christian Egtvedt
2009-12-28 9:59 ` Peter Hüwe
2009-12-28 10:02 ` Hans-Christian Egtvedt
2009-12-28 10:20 ` Haavard Skinnemoen
2009-12-28 10:34 ` Peter Hüwe [this message]
2009-12-28 11:07 ` Hans-Christian Egtvedt
2009-12-28 11:23 ` Hans-Christian Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912281134.36763.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=haavard.skinnemoen@atmel.com \
--cc=hans-christian.egtvedt@atmel.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pma@mediamatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox