From: Ben Dooks <ben-linux@fluff.org>
To: Thomas Abraham <thomas.ab@samsung.com>
Cc: linux-mmc@vger.kernel.org, ben-linux@fluff.org, kgene.kim@samsung.com
Subject: Re: [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller.
Date: Thu, 28 Jan 2010 04:13:34 +0000 [thread overview]
Message-ID: <20100128041334.GQ10014@trinity.fluff.org> (raw)
In-Reply-To: <1264643438-6317-1-git-send-email-thomas.ab@samsung.com>
On Thu, Jan 28, 2010 at 10:50:38AM +0900, Thomas Abraham wrote:
> This patch enables ADMA feature in S3C SDHCI controller driver. This patch
> depends on the following patch.
>
> [PATCH] sdhci: Add new quirk in sdhci driver and update ADMA descriptor build.
>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 7400ba0..03f7e3b 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -341,12 +341,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> host->irq = irq;
>
> /* Setup quirks for the controller */
> -
> - /* Currently with ADMA enabled we are getting some length
> - * interrupts that are not being dealt with, do disable
> - * ADMA until this is sorted out. */
> - host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
> - host->quirks |= SDHCI_QUIRK_32BIT_ADMA_SIZE;
> + host->quirks |= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
>
> #ifndef CONFIG_MMC_SDHCI_S3C_DMA
>
> --
> 1.5.3.4
>
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-01-28 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 1:50 [PATCH-Resend] S3C: sdhci: Enable ADMA feature in S3C sdhci controller Thomas Abraham
2010-01-28 4:13 ` Ben Dooks [this message]
2010-01-28 12:37 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128041334.GQ10014@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox