From: Magnus Damm <magnus.damm@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: sameo@linux.intel.com, linux-sh@vger.kernel.org,
linus.ml.walleij@gmail.com, Magnus Damm <magnus.damm@gmail.com>,
goda.yusuke@renesas.com, ian@mnementh.co.uk, lethal@linux-sh.org,
akpm@linux-foundation.org, g.liakhovetski@gmx.de
Subject: [PATCH 03/05] tmio_mmc: Use 100ms mmc_detect_change() delay
Date: Wed, 17 Feb 2010 16:38:04 +0900 [thread overview]
Message-ID: <20100217073804.32726.27721.sendpatchset@t400s> (raw)
In-Reply-To: <20100217073735.32726.12020.sendpatchset@t400s>
From: Magnus Damm <damm@opensource.se>
This patch changes the tmio_mmc driver to wait 100ms
before checking the card detect status. This type of
delay is quite common among mmc drivers, it seems that
most hardware platforms need to give the hardware some
time to settle before checking card availabilty.
Hotplug is half-broken without this patch on the sh7724
Ecovec board. Hot insertion seems ok but eject is never
detected without this patch.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Previously posted to linux-mmc 20100215 as
"[PATCH] tmio_mmc: use 100ms mmc_detect_change() delay"
drivers/mmc/host/tmio_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/drivers/mmc/host/tmio_mmc.c
+++ work/drivers/mmc/host/tmio_mmc.c 2010-02-15 20:28:15.000000000 +0900
@@ -323,7 +323,7 @@ static irqreturn_t tmio_mmc_irq(int irq,
if (ireg & (TMIO_STAT_CARD_INSERT | TMIO_STAT_CARD_REMOVE)) {
ack_mmc_irqs(host, TMIO_STAT_CARD_INSERT |
TMIO_STAT_CARD_REMOVE);
- mmc_detect_change(host->mmc, 0);
+ mmc_detect_change(host->mmc, msecs_to_jiffies(100));
}
/* CRC and other errors */
next prev parent reply other threads:[~2010-02-17 7:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 7:37 [PATCH 00/05] tmio_mmc: SDHI hotplug and random fixes Magnus Damm
2010-02-17 7:37 ` [PATCH 01/05] tmio_mmc: Keep card-detect interrupts enabled Magnus Damm
2010-02-17 7:37 ` [PATCH 02/05] tmio_mmc: Add MMC_CAP_MMC_HIGHSPEED support V2 Magnus Damm
2010-02-17 7:38 ` Magnus Damm [this message]
2010-02-17 7:38 ` [PATCH 04/05] tmio_mmc: Remove const from platform data V3 Magnus Damm
2010-02-17 7:38 ` [PATCH 05/05] tmio_mmc: Balance cell enable()/disable() calls Magnus Damm
2010-02-19 11:46 ` [PATCH 00/05] tmio_mmc: SDHI hotplug and random fixes Samuel Ortiz
2010-02-22 4:43 ` Magnus Damm
2010-02-28 19:03 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217073804.32726.27721.sendpatchset@t400s \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=g.liakhovetski@gmx.de \
--cc=goda.yusuke@renesas.com \
--cc=ian@mnementh.co.uk \
--cc=lethal@linux-sh.org \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox