From: Andrew Morton <akpm@linux-foundation.org>
To: "Richard Röjfors" <richard.rojfors@pelagicore.com>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>,
David Vrabel <david.vrabel@csr.com>,
Pierre Ossman <pierre@ossman.eu>, Ben Dooks <ben@simtec.co.uk>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] sdhci-pltfm: Do not print errors in case of an extended iomem size
Date: Mon, 22 Mar 2010 12:30:52 -0700 [thread overview]
Message-ID: <20100322123052.10820d0f.akpm@linux-foundation.org> (raw)
In-Reply-To: <4BA0708C.8070402@pelagicore.com>
On Wed, 17 Mar 2010 07:02:52 +0100
Richard R__jfors <richard.rojfors@pelagicore.com> wrote:
> On 3/16/10 7:34 PM, Anton Vorontsov wrote:
> > Some hosts have an extended SDHCI iomem size, so the driver should
> > only print errors if the iomem size is less than 0x100.
>
> With this change you allow a bigger resource than we really need.
> I think you should also change request_mem_region and ioremap to only
> request and map the actual needed size. (0x100)
I merged these three with a note-to-self that some updates are expected
(hint).
next prev parent reply other threads:[~2010-03-22 19:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 18:34 [PATCH resend 0/3] sdhci-pltfm: Few additions and enhancements Anton Vorontsov
2010-03-16 18:34 ` [PATCH 1/3] sdhci: Implement CAP_CLOCK_BASE_BROKEN quirk Anton Vorontsov
2010-03-16 18:34 ` [PATCH 2/3] sdhci-pltfm: Implement platform data passing Anton Vorontsov
2010-03-17 6:14 ` Richard Röjfors
2010-04-23 18:26 ` [PATCH] sdhci-pltfm: Add kernel-doc for struct sdhci_pltfm_data Anton Vorontsov
2010-03-16 18:34 ` [PATCH 3/3] sdhci-pltfm: Do not print errors in case of an extended iomem size Anton Vorontsov
2010-03-17 6:02 ` Richard Röjfors
2010-03-22 19:30 ` Andrew Morton [this message]
2010-04-23 18:25 ` Anton Vorontsov
2010-05-03 6:01 ` Richard Röjfors
-- strict thread matches above, loose matches on Subject: below --
2010-02-19 19:48 Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322123052.10820d0f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avorontsov@ru.mvista.com \
--cc=ben@simtec.co.uk \
--cc=david.vrabel@csr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=richard.rojfors@pelagicore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).