From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Hemanth V <hemanthv@ti.com>,
linux-mmc@vger.kernel.org, pierre@ossman.eu,
saeed bishara <saeed.bishara@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: fix highmem with VIPT cache and DMA
Date: Fri, 26 Mar 2010 23:09:39 +0000 [thread overview]
Message-ID: <20100326230939.GF29179@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.1003261144020.694@xanadu.home>
On Fri, Mar 26, 2010 at 11:51:58AM -0400, Nicolas Pitre wrote:
> On Fri, 26 Mar 2010, Catalin Marinas wrote:
>
> > On Thu, 2010-03-25 at 21:02 +0000, Nicolas Pitre wrote:
> > > --- a/arch/arm/include/asm/highmem.h
> > > +++ b/arch/arm/include/asm/highmem.h
> > > @@ -11,7 +11,11 @@
> > >
> > > #define kmap_prot PAGE_KERNEL
> > >
> > > -#define flush_cache_kmaps() flush_cache_all()
> > > +#define flush_cache_kmaps() \
> > > + do { \
> > > + if (cache_is_vivt()) \
> > > + flush_cache_all(); \
> > > + } while (0)
> >
> > Do the aliasing VIPT caches need flushing as well?
>
> No idea. Highmem is not supported with aliasing VIPT at the moment
> anyway -- see commit 3f973e2216. I don't have hardware with aliasing
> VIPT cache either.
I don't think we'll ever support aliasing VIPT caches with highmem -
it'd quadruple the amount of kmap space that's required for things like
KM_USER*.
prev parent reply other threads:[~2010-03-26 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 21:02 [PATCH] ARM: fix highmem with VIPT cache and DMA Nicolas Pitre
2010-03-26 13:34 ` Catalin Marinas
2010-03-26 15:51 ` Nicolas Pitre
2010-03-26 23:09 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326230939.GF29179@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=hemanthv@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pierre@ossman.eu \
--cc=saeed.bishara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).